Merged
Conversation
abhilashshetty04
approved these changes
Nov 26, 2025
Adds a build derivation for astyle v3.1, since spdk is expecting a version between 3.0.1 and 3.1 but the current nix version is already way ahead. This derivation is copied from an older nixpkgs branch. Adds astyle and a couple of python packages to the none spdk nix shell. Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
Now you can configure with --with-unit-tests Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
tiagolobocastro
force-pushed
the
fix-gerrit
branch
from
b6eef9b to
8f7ccdd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a few tools required when trying to submit a gerrit patch.