Merged
Conversation
Member
tiagolobocastro
commented
Nov 27, 2025
tiagolobocastro
commented
tiagolobocastro
force-pushed
the
fix-spdk
branch
from
a0cc5e1 to
50c8baf
Compare
Previously we had used the include/spdk/module to detect if it was a sandbox or regular build. Since, spdk has created its own include/spdk/module, and broke this. Instead, simply include module/ if it exists. Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
The existing one is broken so use the nix-prefetch-github and add it to the devel shell. Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
tiagolobocastro
force-pushed
the
fix-spdk
branch
from
50c8baf to
ad9f147
Compare
abhilashshetty04
approved these changes
Nov 28, 2025
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.