Skip to content

Conversation

@sarina
Copy link
Contributor

@sarina sarina commented Nov 16, 2025

@sarina sarina marked this pull request as ready for review November 16, 2025 19:26
@sarina sarina requested a review from jswope00 November 16, 2025 19:26
@sarina
Copy link
Contributor Author

sarina commented Dec 2, 2025

@jswope00 or @pdpinch could you take a review of this so we can land it for the Ulmo docs?

Copy link

@Anas12091101 Anas12091101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarina
When we added the new visibility option for subsections (“Never show individual assessment results, but show overall assessment results after the due date”), we also introduced some updates to the Progress page in the Learning MFE, including the new banner (more details in this PR: openedx/frontend-app-learning#1797).

Image

I'm not entirely sure about the intended scope of this PR, but I think we should also document these changes here: https://docsopenedxorg--1322.org.readthedocs.build/en/1322/educators/references/data/progress_page.html.

@sarina sarina force-pushed the sarina/problem-components-update branch from ff94a46 to 14c9ca0 Compare December 10, 2025 23:42
@sarina
Copy link
Contributor Author

sarina commented Dec 10, 2025

@Anas12091101 thank you for your review! I've pushed a commit to address your comments, could you take a look?

Copy link

@Anas12091101 Anas12091101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sarina, Overall LGTM

Just a small change

Comment on lines 59 to 63
* If "Never show individual assessment results, but show overall assessment
results after due date" has been selected, and the due date has not passed, a
banner message will appear on the progress page with the message "Some
assignment scores are not yet included in your total grade. These grades will
be released by {dueDate}."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The banner depends on the due date only and will also be displayed if the “Show When Subsection is Past Due” is selected and the due date of the subsection is in the future

#. A way to add new units to a subsection through the unit navigation bar.
#. A unit navigation bar that shows where in the subsection this unit is
located, and provides easy navigation options to nearby unit pages.
#. Navigation tools to quickly get to other sections or subsections.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not an accurate description of #2

#. A unit navigation bar that shows where in the subsection this unit is
located, and provides easy navigation options to nearby unit pages.
#. Navigation tools to quickly get to other sections or subsections.
#. Options for testing the unit (View Live and Preview), and button to view
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also not accurate. #2 and #3 need to be switched, and working changed from section/subsection navigation to unit navigation.

@sarina
Copy link
Contributor Author

sarina commented Dec 12, 2025

@jswope00 @Anas12091101 - responded in commit

Copy link

@Anas12091101 Anas12091101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sarina sarina merged commit 53e3b7a into main Dec 14, 2025
2 checks passed
@sarina sarina deleted the sarina/problem-components-update branch December 14, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants