-
Notifications
You must be signed in to change notification settings - Fork 78
Update various Educator docs pages #1322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Anas12091101
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarina
When we added the new visibility option for subsections (“Never show individual assessment results, but show overall assessment results after the due date”), we also introduced some updates to the Progress page in the Learning MFE, including the new banner (more details in this PR: openedx/frontend-app-learning#1797).
I'm not entirely sure about the intended scope of this PR, but I think we should also document these changes here: https://docsopenedxorg--1322.org.readthedocs.build/en/1322/educators/references/data/progress_page.html.
source/educators/how-tos/course_development/set_subsection_problem_date.rst
Outdated
Show resolved
Hide resolved
source/educators/how-tos/course_development/set_subsection_problem_date.rst
Outdated
Show resolved
Hide resolved
ff94a46 to
14c9ca0
Compare
|
@Anas12091101 thank you for your review! I've pushed a commit to address your comments, could you take a look? |
Anas12091101
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sarina, Overall LGTM
Just a small change
| * If "Never show individual assessment results, but show overall assessment | ||
| results after due date" has been selected, and the due date has not passed, a | ||
| banner message will appear on the progress page with the message "Some | ||
| assignment scores are not yet included in your total grade. These grades will | ||
| be released by {dueDate}." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The banner depends on the due date only and will also be displayed if the “Show When Subsection is Past Due” is selected and the due date of the subsection is in the future
| #. A way to add new units to a subsection through the unit navigation bar. | ||
| #. A unit navigation bar that shows where in the subsection this unit is | ||
| located, and provides easy navigation options to nearby unit pages. | ||
| #. Navigation tools to quickly get to other sections or subsections. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not an accurate description of #2
| #. A unit navigation bar that shows where in the subsection this unit is | ||
| located, and provides easy navigation options to nearby unit pages. | ||
| #. Navigation tools to quickly get to other sections or subsections. | ||
| #. Options for testing the unit (View Live and Preview), and button to view |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@jswope00 @Anas12091101 - responded in commit |
Anas12091101
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Uh oh!
There was an error while loading. Please reload this page.