fix: add missing space symbol to the 'additional.help.text' field #1521
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @bydawen! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1521 +/- ##
=======================================
Coverage 87.58% 87.58%
=======================================
Files 124 124
Lines 2303 2303
Branches 643 643
=======================================
Hits 2017 2017
Misses 277 277
Partials 9 9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -153,6 +153,7 @@ const ForgotPasswordPage = (props) => { | |||
| )} | |||
| <p className="mt-5.5 small text-gray-700"> | |||
| {formatMessage(messages['additional.help.text'], { platformName })} | |||
There was a problem hiding this comment.
[nit] Please also remove a whitespace in the end of the translation
https://github.com/raccoongang/frontend-app-authn/blob/03af30e8df93caf926f22eb6c0768a215fe07c8f/src/forgot-password/messages.js#L77
There was a problem hiding this comment.
[nit] Please also remove a whitespace in the end of the translation https://github.com/raccoongang/frontend-app-authn/blob/03af30e8df93caf926f22eb6c0768a215fe07c8f/src/forgot-password/messages.js#L77
removed, thx!
bydawen
force-pushed
the
fix/missing-space-in-forgot-password-field
branch
from
668e7fd to
6b9e407
Compare
bydawen
force-pushed
the
fix/missing-space-in-forgot-password-field
branch
from
6b9e407 to
0466364
Compare
Hello, done) |
|
kindly rebase this PR, @bydawen |
bydawen
force-pushed
the
fix/missing-space-in-forgot-password-field
branch
from
0466364 to
5cf1541
Compare
Hi, done! |
ihor-romaniuk
force-pushed
the
fix/missing-space-in-forgot-password-field
branch
from
5cf1541 to
6b035f3
Compare
ihor-romaniuk
force-pushed
the
fix/missing-space-in-forgot-password-field
branch
from
6b035f3 to
2f6e97e
Compare
There is a issue, that almost in all translations there is no space between
"additional.help.text"field and{getConfig().INFO_EMAIL}in the frontend-app-authnTo prevent this, and not to fix all translations files, space symbol was added.