Skip to content

Conversation

Waleed-Mujahid
Copy link

Description

This PR updates the usage of the component in the Authn MFE to use the isInline prop instead of manually passing the "inline-link" class via className.

The isInline prop on the component defaults to false, which causes it to internally apply the standalone-link class in addition to any class passed through className. As a result, both inline-link and standalone-link classes were being applied simultaneously.

This conflict led to styling issues that caused the link to sometimes not render properly or appear invisible, especially in places where visual styling depends heavily on the correct class being applied.

The fix is to use the dedicated isInline prop so only one of the classes is applied

How Has This Been Tested?

Yes I have tested this with tutor local on my server

Screenshots/sandbox (optional):

Before
Screenshot 2025-08-06 at 7 30 53 PM

#After
Screenshot 2025-08-06 at 7 33 32 PM

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/2u-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@Waleed-Mujahid Waleed-Mujahid deleted the waleed/fix-honor-code-link branch August 7, 2025 07:49
@Waleed-Mujahid Waleed-Mujahid restored the waleed/fix-honor-code-link branch August 7, 2025 07:51
@Waleed-Mujahid Waleed-Mujahid reopened this Aug 7, 2025
@Waleed-Mujahid Waleed-Mujahid force-pushed the waleed/fix-honor-code-link branch from a1e17c9 to d3a8100 Compare August 7, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant