Skip to content

TIA-41: Added * for required fields in labels #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

TIA-41: Added * for required fields in labels #774

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
999b6a9
fix: Added * for required fields in labels
May 21, 2025
a4fe4c1
fix: placeholder props added
May 21, 2025
7ec40b9
fix: linter fixes and requested changes added
Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/TinyMCEEditor.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@
relative_urls: false,
default_link_target: '_blank',
target_list: false,
placeholder: props.placeholder,

Check failure on line 155 in src/components/TinyMCEEditor.jsx

View workflow job for this annotation

GitHub Actions / tests 

'placeholder' is missing in props validation
images_upload_handler: uploadHandler,
setup,
}}
Expand Down
1 change: 1 addition & 0 deletions src/discussions/posts/post-editor/PostEditor.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,7 @@
value={values.comment}
onEditorChange={formikCompatibleHandler(handleChange, 'comment')}
onBlur={formikCompatibleHandler(handleBlur, 'comment')}
placeholder={'Post content*'}

Check failure on line 412 in src/discussions/posts/post-editor/PostEditor.jsx

View workflow job for this annotation

GitHub Actions / tests 

Curly braces are unnecessary here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be translated

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

/>
<PostHelpPanel />
<FormikErrorFeedback name="comment" />
Expand Down
2 changes: 1 addition & 1 deletion src/discussions/posts/post-editor/messages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ const messages = defineMessages({
},
postTitle: {
id: 'discussions.post.editor.title',
defaultMessage: 'Post title',
defaultMessage: 'Post title*',
},
titleDescription: {
id: 'discussions.post.editor.titleDescription',
Expand Down
Loading