fix: instructor dashboard add info encoded in the request body#38885
fix: instructor dashboard add info encoded in the request body#38885marslanabdulrauf wants to merge 2 commits into
Conversation
|
Thanks for the pull request, @marslanabdulrauf! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
There was a problem hiding this comment.
This description can be updated to something like "Optional: If 'true', only update scores that are higher than current. " "May be provided as a query parameter or in the request body (JSON boolean or string)."
| course_key, usage_key = parsed | ||
|
|
||
| only_if_higher = request.query_params.get('only_if_higher', 'false').lower() == 'true' | ||
| only_if_higher = _get_only_if_higher(request) |
There was a problem hiding this comment.
It would be great if a unit test were added for this change
657ef65 to
28735a5
Compare
Description
This pull request improves how the
only_if_higherflag is handled in the instructor API for rescoring learners. The main change is to consistently support reading the flag from both query parameters and the request body, matching how the frontend sends data. This also makes the code more robust by accepting both boolean and string values for the flag.Improvements to request handling:
_get_only_if_higherhelper function to extract theonly_if_higherflag from either query parameters or the request body, accepting both string and boolean representations.RescoreViewendpoint and its documentation to clarify thatonly_if_highercan be provided in either the query string or request body.only_if_higherin thepostmethod with the new helper for consistent and reliable extraction.Supporting Information
https://github.com/mitodl/hq/issues/11874 (MIT Internal)
Testing instructions
Steps to Reproduce
Make sure you have a course with graded sub-section with at least one problem(multi-select would do)