Skip to content

include flagTags in postEvaluation and postEvaluationBatch #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

su5kk
Copy link

@su5kk su5kk commented Jul 3, 2025

Motivation and Context

We require the flagTags field that includes all tags related to a particular flag in the response for our internal logic.

How Has This Been Tested?

  • Added validation checks in step_11_test_tag_batch_evaluation to ensure batch evaluations return:
    • flagTags field presence
  • Added validation checks in step_12_test_tag_operator_batch_evaluation to ensure:
    • flagTags field presence

Types of changes

  • Bug fix (non-breaking change which fixes an issue) ?? maybe not exactly a bug-fix

Checklist:

  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@su5kk su5kk force-pushed the eval-context-in-result branch from 8370f42 to b7117af Compare July 3, 2025 11:46
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.51%. Comparing base (770461b) to head (b7117af).
Report is 9 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #623      +/-   ##
==========================================
- Coverage   81.19%   76.51%   -4.68%     
==========================================
  Files          28       30       +2     
  Lines        2271     2419     +148     
==========================================
+ Hits         1844     1851       +7     
- Misses        337      478     +141     
  Partials       90       90              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marceloboeira marceloboeira requested a review from nothing0012 July 3, 2025 13:18
@su5kk su5kk force-pushed the eval-context-in-result branch from b7117af to 75ccfc9 Compare July 23, 2025 10:17
@su5kk su5kk changed the title add eval context to postEvaluation and postEvaluationBatch include flagTags in postEvaluation and postEvaluationBatch Jul 23, 2025
@su5kk su5kk force-pushed the eval-context-in-result branch 2 times, most recently from 637027c to 9ea1aca Compare July 23, 2025 11:04
@su5kk su5kk force-pushed the eval-context-in-result branch from 9ea1aca to a01414f Compare July 23, 2025 11:04
@su5kk
Copy link
Author

su5kk commented Jul 24, 2025

@nothing0012 hello, can you please take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants