-
Notifications
You must be signed in to change notification settings - Fork 25
Skip molecules with zero count in Packmol wrapper #1272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1272 +/- ##
=======================================
Coverage 93.86% 93.86%
=======================================
Files 72 72
Lines 6240 6242 +2
=======================================
+ Hits 5857 5859 +2
Misses 383 383 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nonblocking docs and test recommendations, but otherwise this is good to go! You might also consider explicitly adding Closes #1267 to the body text so the issue is auto-closed.
| See Issue #1267: https://github.com/openforcefield/openff-interchange/issues/1267 | ||
| """ | ||
| topology = pack_box( | ||
| molecules=[caffeine, water, water], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(not blocking) may be a hair more robust if the molecule with zero copies is not a duplicate of another mol in the list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(not blocking) Also could be improved by putting it in the middle of the list, in case some off-by-one issue is being masked by it being at the end
Co-authored-by: Jeff Wagner <[email protected]>

Description
Resolves #1267, independently of #1268
Checklist