Skip to content

Conversation

@mattwthompson
Copy link
Member

Description

Resolves #1267, independently of #1268

Checklist

  • Add tests
  • Lint
  • Update docstrings

@codecov
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.86%. Comparing base (4ce92a9) to head (6deb6f8).
⚠️ Report is 56 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1272   +/-   ##
=======================================
  Coverage   93.86%   93.86%           
=======================================
  Files          72       72           
  Lines        6240     6242    +2     
=======================================
+ Hits         5857     5859    +2     
  Misses        383      383           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mattwthompson mattwthompson marked this pull request as ready for review July 24, 2025 12:16
Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nonblocking docs and test recommendations, but otherwise this is good to go! You might also consider explicitly adding Closes #1267 to the body text so the issue is auto-closed.

See Issue #1267: https://github.com/openforcefield/openff-interchange/issues/1267
"""
topology = pack_box(
molecules=[caffeine, water, water],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not blocking) may be a hair more robust if the molecule with zero copies is not a duplicate of another mol in the list

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not blocking) Also could be improved by putting it in the middle of the list, in case some off-by-one issue is being masked by it being at the end

@mattwthompson
Copy link
Member Author

Thanks for the review!

I always though all closing keywords were the same?

image

I'll leave as-is to see what happens but check on it after

@mattwthompson mattwthompson merged commit 8ad551f into main Jul 24, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

solvate_topology fails if no ions are added.

3 participants