-
Notifications
You must be signed in to change notification settings - Fork 6
Low coord low MW tmQM #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@chrisiacovella before we merge this I'll need links to the source HDF5 for full posterity. I think there's enough here for @lilyminium to take a pass at reviewing, with the knowledge that links to the files will be provided. |
QCSubmit Validation Report
QC Specification Report
QCSubmit version information(click to expand)
|
QCSubmit Validation Report
QC Specification Report
QCSubmit version information(click to expand)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, thanks Jen! My only question is why there are 471097 conformers but 480339 entry names in the dataset? Are there duplicates?
Approving so as to not block if I've missed something obvious.
In the future could you please add a semicolon to suppress output when adding entries -- 400k integers adds a lot of scrolling to the notebook!
Edit: also, why is CI failing on cmiles?
@lilyminium There are duplicate initial coordinates but at a different multiplicity. I supposed those will converge to a different geometry, so I could report it as 480,339 conformers.
Thanks for pointing this out! I didn't see that locally or in the files changed view on GitHub, I'll be sure to look at the raw file in the future.
It's because TMOS is not always able to make a valid SMILES string, so those entries are without, causing an error. |
I see -- thanks! Yeah I think 480339 is clearer and lets users know what dataset size to expect. |
New Submission Checklist
README.md
describing the dataset see here for examplesdataset*.json
; may feature a compression extension, such as.bz2
README.md