#2 abstract test a.2 #68
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented abstract test A.1.1 and its integration test (IT) - Added test URL for execution - Defined execution order
…variables - Updated test suite from Features to Maps to fix mvn build error - Modified testng.xml - Replaced hardcoded test counts with variables to prevent build failures due to mismatched results
…apserver_world_map")
bpross-52n
reviewed
Apr 9, 2025
| public void verifyMapResponse() throws Exception { | ||
| List<URL> urls = MapUtil.fetchMapUrls(rootUri); | ||
|
|
||
| for (URL url : urls) { |
There was a problem hiding this comment.
Looping over all the map URLs can take up a lt of resources for services with many maps/collections. I'd suggest using the noOfCollections parameter as done in the ets-ogcapi-features10.
bpross-52n
requested changes
Apr 9, 2025
bpross-52n
left a comment
bpross-52n
left a comment
There was a problem hiding this comment.
Looks good, the code just needs to be formatted mvn spring-javaformat:apply. See also my comment in the MapResponse.java class.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2