Skip to content

Improve schema for tags #4940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Improve schema for tags #4940

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f7cd32
work in progress
andrewfg Jul 31, 2025
96a23c0
initial contribution
andrewfg Aug 1, 2025
2b4ad5e
use ai to improve
andrewfg Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions bundles/org.openhab.core.thing/schema/thing/thing-description-1.0.0.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
<xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema"
xmlns:thing-description="https://openhab.org/schemas/thing-description/v1.0.0"
xmlns:config-description="https://openhab.org/schemas/config-description/v1.0.0"
targetNamespace="https://openhab.org/schemas/thing-description/v1.0.0">
targetNamespace="https://openhab.org/schemas/thing-description/v1.0.0"
xmlns:vc="http://www.w3.org/2007/XMLSchema-versioning"
vc:minVersion="1.1">

<xs:import namespace="https://openhab.org/schemas/config-description/v1.0.0"
schemaLocation="https://openhab.org/schemas/config-description-1.0.0.xsd"/>
Expand Down Expand Up @@ -216,7 +218,14 @@

<xs:complexType name="tags">
<xs:sequence>
<xs:element name="tag" type="thing-description:semanticPropertyOrPointTag" minOccurs="1" maxOccurs="2"/>
<xs:element name="tag">
<xs:alternative test="position() = 1" type="thing-description:semanticPointTag"/>
<xs:alternative type="xs:error"/>
</xs:element>
<xs:element name="tag" minOccurs="0">
<xs:alternative test="position() = 2" type="thing-description:semanticPropertyTag"/>
<xs:alternative type="xs:error"/>
</xs:element>
</xs:sequence>
</xs:complexType>

Expand Down Expand Up @@ -271,7 +280,7 @@
</xs:simpleContent>
</xs:complexType>

<xs:simpleType name="semanticPropertyOrPointTag">
<xs:simpleType name="semanticPropertyTag">
<xs:restriction base="xs:string">
<!-- Begin Allowed Semantic Property Tag Values -->
<!-- DO NOT EDIT THIS LIST - Generated by generateTagClasses.groovy -->
Expand Down Expand Up @@ -339,7 +348,11 @@
<xs:enumeration value="Water"/>
<xs:enumeration value="Wind"/>
<!-- End Allowed Semantic Property Tag Values -->
</xs:restriction>
</xs:simpleType>

<xs:simpleType name="semanticPointTag">
<xs:restriction base="xs:string">
<!-- Begin Allowed Semantic Point Tag Values -->
<!-- DO NOT EDIT THIS LIST - Generated by generateTagClasses.groovy -->
<xs:enumeration value="Alarm"/>
Expand Down
Loading