Refactor BusEvent to ScriptExtension #5064
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comparable to openhab#3155. JSR-223 automation add-ons often use the script actions from the org.openhab.core.model.script bundle. The downside is that the actions are tied to XText or at least use some hacks to provide static access to OSGi services. This refactors the BusEvent actions, making them available as ScriptExtension via import-preset ScriptAction. The actions are wrapped for DSL rules, to stay backward compatible. Signed-off-by: Florian Hotze <[email protected]>
florian-h05
force-pushed
the
busevent-rfc
branch
from
ef7fc4f to
da6acb7
Compare
|
@ccutrer I would like to get this merged before implementing support for sending event source through BusEvent actions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparable to #3155.
JSR-223 automation add-ons often use the script actions from the org.openhab.core.model.script bundle. The downside is that the actions are tied to XText or at least use some hacks to provide static access to OSGi services.
This refactors the BusEvent actions, making them available as ScriptExtension via import-preset ScriptAction. The actions are wrapped for DSL rules, to stay backward compatible.