Skip to content

[rest] PersistenceResource: Update OpenAPI annotation itemname => itemName#5400

Merged
holgerfriedrich merged 1 commit intoopenhab:mainfrom
florian-h05:patch-1
Mar 15, 2026
Merged

[rest] PersistenceResource: Update OpenAPI annotation itemname => itemName#5400
holgerfriedrich merged 1 commit intoopenhab:mainfrom
florian-h05:patch-1

Conversation

@florian-h05
Copy link
Copy Markdown
Contributor

This aligns with the spelling of itemName in other places in the Swagger annotations.

…mName

Signed-off-by: Florian Hotze <dev@florianhotze.com>
@florian-h05 florian-h05 requested a review from a team as a code owner March 2, 2026 12:16
@holgerfriedrich
Copy link
Copy Markdown
Member

@mherwege
Copy link
Copy Markdown
Contributor

This is a breaking change, so in my view, it’s better to separate them out.

I am in support of changing it, but if there is any other consumer than the UI for this, they may have to be adapted.

@florian-h05
Copy link
Copy Markdown
Contributor Author

Support for providing a Item name to this endpoint is pretty new and hasn’t been released yet, so I think it’s unlikely an external system uses this.

@florian-h05
Copy link
Copy Markdown
Contributor Author

But I agree it’s better to merge this separately.

@jsjames
Copy link
Copy Markdown
Contributor

jsjames commented Mar 15, 2026

If this gets merged first, then we don't need to make changes to #5404, correct? Or, do you want me to back out this from #5404?

@mherwege
Copy link
Copy Markdown
Contributor

Support for providing a Item name to this endpoint is pretty new and hasn’t been released yet, so I think it’s unlikely an external system uses this.

Correct. I should have remembered as I introduced it.

@holgerfriedrich holgerfriedrich merged commit 1341eda into openhab:main Mar 15, 2026
5 checks passed
@holgerfriedrich holgerfriedrich added the enhancement An enhancement or new feature of the Core label Mar 15, 2026
@holgerfriedrich holgerfriedrich added this to the 5.2 milestone Mar 15, 2026
@florian-h05 florian-h05 deleted the patch-1 branch March 16, 2026 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement An enhancement or new feature of the Core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants