Persistence timeseries fix updating Item state by mherwege · Pull Request #5403 · openhab/openhab-core

mherwege · 2026-03-05T15:42:57Z

It has been reported a few time that a timeSeries did not update the Item state when passing the timeSeries entry timestamp.

The issue is that persisting a timeSeries from the persistence extension persist method did not get the forecast job running. As long as there were future values in the timeSeries, updating the timeSeries would keep the logic going. But once the timeSeries runs out, a new timeSeries provided through persistence extensions did not start the job anymore. Restarting or resaving the Item would also solve this and get it running again.
This issue is fixed with this PR.

Second, as noted in the second issue to be closed, loading a timeSeries with values in the past would not update the Item state. Restarting openHAB afterwards would if a restoreOnStartup strategy is configured.
While I think it is a bad idea to blindly set the Item state with values from a timeSeries that is being loaded, there certainly is improvement possible. My proposed solution is: if a timeSeries is loaded with values in the past, look for the last value in the past. If the timestamp of that value is later then the Item's last update timestamp, use the value from the timeSeries to set the Item state. As persistence is not involved in this check (it is only the Item's internal state and timestamps), this is only dependent on the Item's state and not if it is persisted or not.
This makes using timeSeries for updating past values more consistent, and will also make sure the item still gets updated when a timeSeries with forecast data is loaded late, after the previous values ran out.

As a logical consequence of 2, I also implemented logic to respect UPDATE and CHANGE strategies for other persistence services (not the one getting the new FORECAST with elements in the past). If the Item state gets updated because a new past state replaced the (older) state of the item, other persistence services then the one from the FORECAST will get their UPDATE or CHANGE strategy applied and a record will be persisted if needed.

Also see https://community.openhab.org/t/a-few-issue-with-time-series/168678
Also see https://community.openhab.org/t/energy-forecast-binding/168567/30

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

when persisting or removing Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

timeseries Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

manager Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

....persistence/src/main/java/org/openhab/core/persistence/internal/PersistenceManagerImpl.java

...persistence/src/main/java/org/openhab/core/persistence/extensions/PersistenceExtensions.java

...istence/src/test/java/org/openhab/core/persistence/extensions/PersistenceExtensionsTest.java

....persistence/src/test/java/org/openhab/core/persistence/internal/PersistenceManagerTest.java

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

....persistence/src/main/java/org/openhab/core/persistence/internal/PersistenceManagerImpl.java

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-06T07:02:08Z

....persistence/src/main/java/org/openhab/core/persistence/internal/PersistenceManagerImpl.java

    public void handleExternalPersistenceDataChange(PersistenceService persistenceService, Item item) {
+        if (!(persistenceService instanceof QueryablePersistenceService)) {
+            return;
+        }
        persistenceServiceContainers.values().stream()
-                .filter(container -> container.persistenceService.equals(persistenceService) && container
-                        .getMatchingConfigurations(FORECAST).anyMatch(itemConf -> appliesToItem(itemConf, item)))
-                .forEach(container -> container.scheduleNextPersistedForecastForItem(item.getName()));
+                .filter(container -> container.persistenceService.equals(persistenceService) && Stream
+                        .concat(container.getMatchingConfigurations(UPDATE),
+                                container.getMatchingConfigurations(FORECAST))
+                        .distinct().anyMatch(itemConf -> appliesToItem(itemConf, item)))
+                .forEach(container -> {
+                    container.scheduleNextPersistedForecastForItem(item.getName());
+                    PersistedItem persistedItem = container.getPersistedItem(item);
+                    if (persistedItem != null) {
+                        container.restoreItemState(item, persistedItem);
+                    }
+                });
    }


The handleExternalPersistenceDataChange method has been significantly expanded (now includes getPersistedItem query and restoreItemState) but there are no tests for it in PersistenceManagerTest. Consider adding a test that verifies:

The early return for non-queryable persistence services

The item state restoration behavior when external persistence data changes

The forecast scheduling after an external data change

The PersistenceExtensionsTest only verifies that handleExternalPersistenceDataChange is called on the mock, but doesn't verify the internal behavior of the method itself.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

....persistence/src/main/java/org/openhab/core/persistence/internal/PersistenceManagerImpl.java

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

....persistence/src/main/java/org/openhab/core/persistence/internal/PersistenceManagerImpl.java

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

....openhab.core.persistence/src/main/java/org/openhab/core/persistence/PersistenceManager.java

....persistence/src/main/java/org/openhab/core/persistence/internal/PersistenceManagerImpl.java

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

holgerfriedrich

LGTM, thanks!

mherwege added 6 commits March 5, 2026 16:28

correct alias when storing timeseries

08e0fc8

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

call handleExternalPersistenceDataChange from persistence extensions

98028a8

when persisting or removing Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

set item state if current state update time before restored entry in

0600f2d

timeseries Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

improve restoring item state

489a068

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

test persistence extensions changes call handlePersistenceDataChange in

3314d0a

manager Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

test restore item state on timeseries update

554dd94

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

mherwege requested a review from a team as a code owner March 5, 2026 15:42

also update from timeseries if equal timestamp

170b883

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

mherwege changed the title ~~Persistence timeseries fix updating item State~~ Persistence timeseries fix updating Item state Mar 5, 2026

mherwege marked this pull request as draft March 5, 2026 16:04

spotless

8d90658

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

mherwege marked this pull request as ready for review March 5, 2026 16:24

wborn requested a review from Copilot March 5, 2026 16:38

Copilot AI reviewed Mar 5, 2026

View reviewed changes

mherwege added 2 commits March 5, 2026 18:38

simplify

cb2033f

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

handle external persistence update with update configuration

c59b9c9

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

mherwege requested a review from Copilot March 5, 2026 19:43

Copilot AI reviewed Mar 5, 2026

View reviewed changes

mherwege requested a review from Copilot March 5, 2026 20:33

Copilot AI reviewed Mar 5, 2026

View reviewed changes

copilot review

c948079

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

mherwege requested a review from Copilot March 5, 2026 21:03

Copilot started reviewing on behalf of mherwege March 5, 2026 21:03 View session

Copilot AI reviewed Mar 5, 2026

View reviewed changes

....persistence/src/main/java/org/openhab/core/persistence/internal/PersistenceManagerImpl.java Show resolved Hide resolved

....persistence/src/main/java/org/openhab/core/persistence/internal/PersistenceManagerImpl.java Outdated Show resolved Hide resolved

mherwege marked this pull request as draft March 6, 2026 06:33

copilot feedback

f588c4f

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

mherwege requested a review from Copilot March 6, 2026 06:49

Copilot started reviewing on behalf of mherwege March 6, 2026 06:50 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

update other persistence services when updating item

8b9646c

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

mherwege added 3 commits March 6, 2026 09:23

simplify

aac3c2c

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

test other persistence services get update after timeseries update

5869383

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

align and deduplicate item state restore logic

196da44

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

mherwege requested a review from Copilot March 6, 2026 13:53

Copilot started reviewing on behalf of mherwege March 6, 2026 13:54 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

....persistence/src/main/java/org/openhab/core/persistence/internal/PersistenceManagerImpl.java Outdated Show resolved Hide resolved

fix bug

763b26b

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

mherwege requested a review from Copilot March 6, 2026 14:17

Copilot started reviewing on behalf of mherwege March 6, 2026 14:18 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

....persistence/src/main/java/org/openhab/core/persistence/internal/PersistenceManagerImpl.java Show resolved Hide resolved

simplify and document

29e5341

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

mherwege requested a review from Copilot March 6, 2026 16:52

Copilot started reviewing on behalf of mherwege March 6, 2026 16:53 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

....openhab.core.persistence/src/main/java/org/openhab/core/persistence/PersistenceManager.java Outdated Show resolved Hide resolved

....persistence/src/main/java/org/openhab/core/persistence/internal/PersistenceManagerImpl.java Show resolved Hide resolved

fix

060a70e

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

mherwege requested a review from Copilot March 8, 2026 17:01

Copilot started reviewing on behalf of mherwege March 8, 2026 17:02 View session

spotless

0a2c16c

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

Copilot AI reviewed Mar 8, 2026

View reviewed changes

mherwege marked this pull request as ready for review March 8, 2026 17:29

holgerfriedrich approved these changes Mar 15, 2026

View reviewed changes

holgerfriedrich merged commit 775f2b3 into openhab:main Mar 15, 2026
5 checks passed

holgerfriedrich added the bug An unexpected problem or unintended behavior of the Core label Mar 15, 2026

holgerfriedrich added this to the 5.2 milestone Mar 15, 2026

mherwege deleted the persistence_timeseries branch March 15, 2026 12:03

Uh oh!

Conversation

mherwege commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

holgerfriedrich left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mherwege commented Mar 5, 2026 •

edited

Loading