[modbus] Make receive timeout configurable for TCP connections - #5805
Merged
Conversation
Closes openhab#5804 Signed-off-by: Stefan Triller <github@stefantriller.de>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds configurable TCP receive timeouts to the Modbus transport.
Changes:
- Adds
receiveTimeoutMillisto endpoint pool configuration. - Applies the configured timeout to TCP connections.
- Includes the setting in equality, hashing, and diagnostics.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
ModbusSlaveConnectionFactoryImpl.java |
Applies receive timeout to TCP connections. |
EndpointPoolConfiguration.java |
Defines and tracks receive-timeout configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ssalonen
approved these changes
Aug 27, 2026
ssalonen
left a comment
ssalonen
left a comment
Contributor
There was a problem hiding this comment.
Copilot suggested good ones
Approving this anyways, commenting on consistency with previous implementation, keeping defaults in one place
Signed-off-by: Stefan Triller <github@stefantriller.de>
Contributor
Author
|
Is there anything missing from my side? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5804