Skip to content

Conversation

mherwege
Copy link
Contributor

@mherwege mherwege commented Apr 1, 2025

Signed-off-by: Mark Herwege <[email protected]>
Copy link

netlify bot commented Apr 1, 2025

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Built without sensitive environment variables

Name Link
🔨 Latest commit 5b81909
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/67ebe817679775000815e04c
😎 Deploy Preview https://deploy-preview-2478--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stefan-hoehn stefan-hoehn added this to the 5.0 milestone Apr 7, 2025
@stefan-hoehn stefan-hoehn merged commit 211d8f2 into openhab:main Apr 7, 2025
4 checks passed
@mherwege
Copy link
Contributor Author

mherwege commented Apr 7, 2025

This ws a bit too quick, as the core PR has not been merged. At the same time, I actually think it is better to phrase the constraint (although it will still work without defining a strategy today).

@stefan-hoehn
Copy link
Contributor

Oh I am sorry. Usually I double check the linked PR which I forgot this time 😩.

@florian-h05
Copy link
Contributor

@mherwege Let me give you a tip to avoid having something merged before it has been ready for it.
When creating a new PR, you can click on the drop down button besides the green PR create button and create a draft. Or you can convert an existing PR into draft at the PR “settings” (labels, assignees etc). Drafts cannot be merged without explicitly converting them back to a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants