Skip to content

(feat) O3-5858: Load carbon and carbon-icons as shared peer dependencies - #3549

Draft
omsrivastava512 wants to merge 2 commits into
openmrs:mainfrom
omsrivastava512:feat/O3-5858-add-carbon-peer-deps-patient-chart
Draft

(feat) O3-5858: Load carbon and carbon-icons as shared peer dependencies#3549
omsrivastava512 wants to merge 2 commits into
openmrs:mainfrom
omsrivastava512:feat/O3-5858-add-carbon-peer-deps-patient-chart

Conversation

@omsrivastava512

@omsrivastava512 omsrivastava512 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work is based on designs, which are linked or shown either in the Jira ticket or the description below. (See also: Styleguide)
  • My work includes tests or is validated by existing tests.

Summary

This PR implements O3-5858, ensuring that @carbon/react and @carbon/icons-react are loaded as shared singletons across all openmrs-esm-patient-chart microfrontends rather than being bundled individually.

Changes Made

  • Removed @carbon/react from standard dependencies across all React-based patient chart apps.
  • Added @carbon/react: 1.x and @carbon/icons-react: 11.x to peerDependencies in all applicable apps.
  • Ran yarn install to update yarn.lock and validate the new dependency graph.

Verification Steps

  • Dependency Check: Verified that no app is bundling its own @carbon/react and all are properly specifying it as a peer dependency.
  • Version Matching: Ensured version specifiers (1.x for @carbon/react and 11.x for @carbon/icons-react) match the shell's provided singletons exactly to prevent version mismatch runtime errors.
  • Automated Tests: Validated that the monorepo build passes and all test suites pass with yarn verify.

Screenshots

n/a

Related Issue

https://openmrs.atlassian.net/browse/O3-5858

Other

@omsrivastava512 omsrivastava512 changed the title (feat) O3-5858: load carbon and carbon-icons as shared peer dependencies (feat) O3-5858: Load carbon and carbon-icons as shared peer dependencies Aug 5, 2026
@omsrivastava512
omsrivastava512 force-pushed the feat/O3-5858-add-carbon-peer-deps-patient-chart branch from f268d9c to a7a51e5 Compare August 5, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant