(feat) O3-5858: Load carbon and carbon-icons as shared peer dependencies - #3549
Draft
omsrivastava512 wants to merge 2 commits into
Draft
Conversation
omsrivastava512
force-pushed
the
feat/O3-5858-add-carbon-peer-deps-patient-chart
branch
from
August 5, 2026 18:36
f268d9c to
a7a51e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR implements O3-5858, ensuring that @carbon/react and @carbon/icons-react are loaded as shared singletons across all openmrs-esm-patient-chart microfrontends rather than being bundled individually.
Changes Made
@carbon/reactfrom standarddependenciesacross all React-based patient chart apps.@carbon/react: 1.xand@carbon/icons-react: 11.xtopeerDependenciesin all applicable apps.yarn installto updateyarn.lockand validate the new dependency graph.Verification Steps
@carbon/reactand all are properly specifying it as a peer dependency.1.xfor@carbon/reactand11.xfor@carbon/icons-react) match the shell's provided singletons exactly to prevent version mismatch runtime errors.yarn verify.Screenshots
n/a
Related Issue
https://openmrs.atlassian.net/browse/O3-5858
Other