RESTWS-760: changed the way the drug property was accessed to represe… #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mherman22
reviewed
Apr 23, 2025
| import org.openmrs.Order; | ||
| import org.openmrs.OrderType; | ||
|
|
||
| import static org.junit.Assert.*; |
There was a problem hiding this comment.
We generally dont recommend wildcards. Have a look at the conventions at https://openmrs.atlassian.net/wiki/x/tL_EAQ
| import org.springframework.beans.factory.annotation.Autowired; | ||
| import org.junit.Before; | ||
| import static org.junit.Assert.*; | ||
| import static org.hamcrest.CoreMatchers.is; |
There was a problem hiding this comment.
| import org.openmrs.module.webservices.rest.web.resource.impl.NeedsPaging; | ||
| import org.openmrs.module.webservices.rest.web.response.ResourceDoesNotSupportOperationException; | ||
| import org.openmrs.module.webservices.rest.web.v1_0.resource.openmrs1_8.DrugOrderSubclassHandler1_8; | ||
| //import org.openmrs.module.webservices.rest.web.representation.SimpleObject; |
There was a problem hiding this comment.
Suggested change
| //import org.openmrs.module.webservices.rest.web.representation.SimpleObject; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RESTWS-760 Order resource does not include drug strength
https://openmrs.atlassian.net/browse/RESTWS-760
Description of what I changed
changed the way the drug property was added from d.addProperty("drug", Representation.REF) to d.addProperty("drug", Representation.DEFAULT) in the DrugOrderSubclassHandler1_10 class
Added unit test in the DrugOrderSubclassHandler1_10Test2 class