Conversation
…mp_engine
- Remove hacky startswith('schedule ') string-splitting path in CLI
dispatch; the nargs='*' argparse path handles the case already
- Remove unused local load_config() in snmp_engine that shadowed
the imported load_base_config and duplicated the centralized parser
- Remove dead imports (json, os, resource_path, runtime_path) from snmp_engine
Shows a 20-char progress bar with percentage mapped to scan phases (ICMP 30%, TCP 60%, enrichment 85%, done 100%) plus elapsed time. Timer resets on each new scan.
…ures - Cut port list from 9 to 5 (80, 443, 445, 3389, 22) - Cap max_candidates at 128 (was formula-based, could reach 960) - Hardcoded tcp_timeout at 0.3s instead of variable formula - Add type annotations to all processor.py public functions - Remove unused get_system_status import from main.py
…o int
Also normalize lone lowercase add_log_entry('info', ...) to 'INFO'.
- New src/backend/incremental.py: split_targets() categorizes hosts by temporal state (seen >= 2, no flaps → cached; else fresh) - Cached hosts skip expensive WMI/SNMP probes; enrichment data comes from previous database sightings instead - ICMP sweep still runs for all hosts (fast with raw sockets) - 16 unit tests covering stability criteria, splitting, and database-backed cached host data retrieval
…ental scan - New test_e2e_smoke.py: 4 integration tests covering full pipeline (all phases, ingestion, scope deny, empty network) - Fix 4 enrichment tests to mock split_targets — incremental scan now splits hosts into cached/fresh, changing target counts
Silently return empty results when asset_sightings/canonical_assets tables haven't been created (first-ever scan). Prevents OperationalError in tests that run discover_all without init_db.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.