Skip to content

Conversation

@lunalzm
Copy link

@lunalzm lunalzm commented May 21, 2025

Description

This change modifies the existing functionality to transform the flyout into a dedicated page jump when the "Data Insights" button is clicked. Additionally, the generative dashboard will no longer save automatically. Instead, after generating the dashboard, users will be redirected to the dashboards page where they can edit and save their modifications independently.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test.
  • New functionality has user manual doc added.
  • Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented May 21, 2025

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.13%. Comparing base (85e5a64) to head (a7e1b20).

Files with missing lines Patch % Lines
server/routes/text2viz_routes.ts 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #577      +/-   ##
==========================================
+ Coverage   82.03%   82.13%   +0.10%     
==========================================
  Files          97       97              
  Lines        2916     2933      +17     
  Branches      666      680      +14     
==========================================
+ Hits         2392     2409      +17     
  Misses        523      523              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yubonluo
Copy link
Contributor

Open question: During generating a dashboard, if there is a failed visualization, could the user navigate to the dashboard page with other successful visualizations?

@lunalzm
Copy link
Author

lunalzm commented May 27, 2025

Open question: During generating a dashboard, if there is a failed visualization, could the user navigate to the dashboard page with other successful visualizations?

Yes, the user could navigate to the dashboard page with the successful visualizations. However, a warning toast will be displayed to inform the user about the visualizations that failed to generate. This way, the user is aware of any issues while still being able to access the functioning parts of the dashboard.

@lunalzm lunalzm force-pushed the feature-generative-dashboards branch from 756ba1c to 7c489ab Compare September 1, 2025 05:36
@ruanyl ruanyl changed the title Generative dashboard: Jump to a dedicated page after click "data insights" button feature: add generative dashboard Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants