Skip to content

Conversation

@dbwiddis
Copy link
Member

@dbwiddis dbwiddis commented Nov 5, 2025

Description

  • Updates gradle to 9.2.0 (Done in chore(deps): update gradle to v9.2.0 #1262 but changing to "all")
  • Updates CI to use JDK 25
  • Fixes BWC to use Maven url
  • Resolves some JAR hell with latest upstream dependency changes
  • Cherry-picks other dependency update PRs to fix all at once

Related Issues

Resolves #1265

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dbwiddis
Copy link
Member Author

dbwiddis commented Nov 5, 2025

Looks like JDK 25 signatures are not available yet?

➜  flow-framework git:(gha-to-jdk25) ./gradlew clean forbiddenAPIsMain --stacktrace
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 9.2.0
  OS Info               : Mac OS X 15.7.1 (aarch64)
  JDK Version           : 25 (Homebrew JDK 25 (25.0.1))
  JAVA_HOME             : /opt/homebrew/Cellar/openjdk/25.0.1/libexec/openjdk.jdk/Contents/Home
  Random Testing Seed   : 8D5CC4328D658376
  Crypto Standard       : any-supported
=======================================

> Task :compileJava
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

> Task :forbiddenApisMain FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':forbiddenApisMain'.
> IO problem while reading files with API signatures.

* Exception is:
org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':forbiddenApisMain'.
...
Caused by: org.gradle.api.GradleException: IO problem while reading files with API signatures.
        at de.thetaphi.forbiddenapis.gradle.CheckForbiddenApis.checkForbidden(CheckForbiddenApis.java:646)
...
Caused by: java.io.FileNotFoundException: Bundled signatures resource not found: jdk-deprecated-25
        at de.thetaphi.forbiddenapis.Signatures.addBundledSignatures(Signatures.java:295)
        at de.thetaphi.forbiddenapis.Signatures.addBundledSignatures(Signatures.java:345)
        at de.thetaphi.forbiddenapis.Checker.addBundledSignatures(Checker.java:335)
        at de.thetaphi.forbiddenapis.gradle.CheckForbiddenApis.checkForbidden(CheckForbiddenApis.java:617)
        ... 119 more


BUILD FAILED in 14s

cc: @peterzhuamazon

@dbwiddis
Copy link
Member Author

dbwiddis commented Nov 5, 2025

We have this dependency:

forbiddenApisCliJar
\--- de.thetaphi:forbiddenapis:3.8

@dbwiddis dbwiddis changed the title Update gradle wrapper to 9.2 and CI to JDK 25 Update CI to JDK 25 Nov 5, 2025
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.79%. Comparing base (700e4d9) to head (a46fe8d).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1266      +/-   ##
============================================
- Coverage     77.84%   77.79%   -0.06%     
  Complexity     1223     1223              
============================================
  Files           103      103              
  Lines          5778     5778              
  Branches        599      599              
============================================
- Hits           4498     4495       -3     
- Misses          992      996       +4     
+ Partials        288      287       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbwiddis dbwiddis force-pushed the gha-to-jdk25 branch 3 times, most recently from 9e04c28 to f9cc68d Compare November 10, 2025 18:50
dbwiddis and others added 5 commits November 10, 2025 11:26
Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com>
Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com>
Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com>
Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com>
@dbwiddis dbwiddis merged commit a6299aa into opensearch-project:main Nov 10, 2025
36 of 37 checks passed
@dbwiddis dbwiddis deleted the gha-to-jdk25 branch November 10, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Release 3.4.0] Gradle 9.2.0 and GitHub Actions JDK 25 Upgrade

3 participants