Enforce size limit for SearchIndexTool #4386
Open
+59
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yyfamazon <[email protected]>
yyfamazon
requested review from
HenryL27,
Zhangxunmt,
austintlee,
b4sjoo,
dhrubo-os,
jngz-es,
mingshl,
model-collapse,
pyek-bot,
rbhavna,
sam-herman,
xinyual,
ylwu-amzn and
zane-neo
as code owners
xinyual
reviewed
Nov 3, 2025
|
|
||
| if (StringUtils.isNotEmpty(parameters.get(SIZE_FIELD))) { | ||
| try { | ||
| size = Math.min(size == null ? 100 : size, Integer.parseInt(parameters.get(SIZE_FIELD))); |
There was a problem hiding this comment.
The size here is also generated by LLM, right? Only when LLM doesn't generate anything we will use the default size 100 in PER agent.
|
Please apply spotless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enforce size limit for SearchIndexTool.
PER agent rely on LLM to generate DSL then call SearchIndexTool to execute the DSL. There is no size limit enforced by SearchIndexTool, if LLM generate a DSL that returns 1000 or even more data, SearchIndexTool will do so and when the result sending back to agent as context, it will fail due to Input is too long for requested model error. We need to add a size limit for SearchIndexTool to return at most 100? records no matter what's the size value is set by LLM.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.