generated from amazon-archives/__template_Custom
-
Notifications
You must be signed in to change notification settings - Fork 184
make credential optional in mcp connectors #4395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jiapingzeng
wants to merge
1
commit into
opensearch-project:main
Choose a base branch
from
jiapingzeng:optional-mcp-credentials
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
make credential optional in mcp connectors #4395
jiapingzeng
wants to merge
1
commit into
opensearch-project:main
from
jiapingzeng:optional-mcp-credentials
+22
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiaping Zeng <[email protected]>
314f1ff to
5ed42b5
Compare
rithin-pullela-aws
approved these changes
Nov 4, 2025
|
Test failures don't seem related to my change: |
Zhangxunmt
approved these changes
Nov 5, 2025
pyek-bot
approved these changes
Nov 5, 2025
ylwu-amzn
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment, MCP connector requires a
credentialsfield. However, credentials is not always needed for remote MCP servers. This PR will make it optional.Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.