Skip to content

Conversation

@jiapingzeng
Copy link
Contributor

@jiapingzeng jiapingzeng commented Nov 4, 2025

Description

At the moment, MCP connector requires a credentials field. However, credentials is not always needed for remote MCP servers. This PR will make it optional.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jiapingzeng jiapingzeng force-pushed the optional-mcp-credentials branch from 314f1ff to 5ed42b5 Compare November 4, 2025 10:23
@jiapingzeng jiapingzeng had a problem deploying to ml-commons-cicd-env-require-approval November 4, 2025 10:25 — with GitHub Actions Failure
@jiapingzeng jiapingzeng had a problem deploying to ml-commons-cicd-env-require-approval November 4, 2025 10:25 — with GitHub Actions Error
@jiapingzeng jiapingzeng had a problem deploying to ml-commons-cicd-env-require-approval November 4, 2025 10:25 — with GitHub Actions Error
@jiapingzeng jiapingzeng had a problem deploying to ml-commons-cicd-env-require-approval November 4, 2025 10:25 — with GitHub Actions Failure
@jiapingzeng
Copy link
Contributor Author

Test failures don't seem related to my change:

Tests with failures:
 - org.opensearch.ml.utils.IndexUtilsTests.testGetNumberOfDocumentsInIndex_SearchQuery
 - org.opensearch.ml.utils.IndexUtilsTests.testGetIndexHealth_Alias
 - org.opensearch.ml.utils.IndexUtilsTests.testGetIndexHealth_Index
Tests with failures:
 - org.opensearch.ml.action.execute.ExecuteITTests.testExecuteLocalSampleCalculator
 - org.opensearch.ml.action.prediction.PredictionITTests.testPredictionWithDataFrame_LinearRegression
 - org.opensearch.ml.action.prediction.PredictionITTests.testPredictionWithoutDataset_KMeans
 - org.opensearch.ml.action.prediction.PredictionITTests.testPredictionWithDataFrame_FitRCF
 - org.opensearch.ml.action.prediction.PredictionITTests.testPredictionWithSearchInput_LogisticRegression
 - org.opensearch.ml.action.prediction.PredictionITTests.testPredictionWithDataFrame_BatchRCF
 - org.opensearch.ml.action.trainpredict.TrainAndPredictITTests.testTrainAndPredict_BatchRCF
 - org.opensearch.ml.action.trainpredict.TrainAndPredictITTests.testTrainAndPredictWithEmptyDataset_KMeans
 - org.opensearch.ml.utils.IndexUtilsTests.testGetIndexHealth_NoIndex
 - org.opensearch.ml.action.models.SearchModelITTests.test_all

@jiapingzeng jiapingzeng had a problem deploying to ml-commons-cicd-env-require-approval November 5, 2025 02:37 — with GitHub Actions Failure
@jiapingzeng jiapingzeng had a problem deploying to ml-commons-cicd-env-require-approval November 5, 2025 02:37 — with GitHub Actions Failure
@jiapingzeng jiapingzeng had a problem deploying to ml-commons-cicd-env-require-approval November 5, 2025 02:37 — with GitHub Actions Error
@jiapingzeng jiapingzeng had a problem deploying to ml-commons-cicd-env-require-approval November 5, 2025 02:37 — with GitHub Actions Error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants