SREP-1216: Added E2E Test - Delete the ClusterDeployment

[drakshakhan]

This PR ensures that deleting a ClusterDeployment with the finalizer certificaterequests.certman.managed.openshift.io automatically deletes the associated CertificateRequest and primary-cert-bundle-secret. The deletion process has been verified to work as expected.

To run the test case, you need to export the below environment variable:
DISABLE_JUNIT_REPORT=false

To run the test:
go test -tags=osde2e ./test/e2e -v

output -
output.txt
output2.txt

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: drakshakhan
Once this PR has been reviewed and has the lgtm label, please assign sam-nguyen7 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[drakshakhan]

/label tide/merge-method-squash

[openshift-ci-robot]

@drakshakhan: This pull request references SREP-1216 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

This PR ensures that deleting a ClusterDeployment with the finalizer certificaterequests.certman.managed.openshift.io automatically deletes the associated CertificateRequest and primary-cert-bundle-secret. The deletion process has been verified to work as expected.

To run the test case, you need to export two environment variables:
DISABLE_JUNIT_REPORT=false
CLUSTER_NAME=cluster-name

To run the test:
go test -tags=osde2e ./test/e2e -v

output -
output.txt
output2.txt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@drakshakhan: This pull request references SREP-1216 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

This PR ensures that deleting a ClusterDeployment with the finalizer certificaterequests.certman.managed.openshift.io automatically deletes the associated CertificateRequest and primary-cert-bundle-secret. The deletion process has been verified to work as expected.

To run the test case, you need to export the below environment variable:
DISABLE_JUNIT_REPORT=false

To run the test:
go test -tags=osde2e ./test/e2e -v

output -
output.txt
output2.txt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[bmeng]

Delete clusterdeployment is not part of the functionality of the certman-operator.

So we should not test like this. Instead, we can update it like following test scenarios.

- certman-opreator finalizer should not block clusterdeployment being deleted
- certificaterequest should be deleted when the clusterdeployment being deleted
- primary-cert-bundle-secret should be deleted accordingly when the clusterdeployment being deleted

[bmeng]

As we discussed in the sync meet, please try to create the clusterdeployment is a separated namespace rather than the certman-operator

[bmeng]

we should not remove the finalizer manually here. It needs to be handled by the operator/controller.

[openshift-ci]

@drakshakhan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.87%. Comparing base (ab78e63) to head (6d11506).
⚠️ Report is 32 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #368      +/-   ##
==========================================
+ Coverage   49.00%   51.87%   +2.86%     
==========================================
  Files          29       29              
  Lines        2116     2138      +22     
==========================================
+ Hits         1037     1109      +72     
+ Misses        973      922      -51     
- Partials      106      107       +1     

see 5 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.