-
Notifications
You must be signed in to change notification settings - Fork 79
SREP-1215: E2E delete primary cert bundle secret if exist #372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
SREP-1215: E2E delete primary cert bundle secret if exist #372
Conversation
@karanjitsingh01: This pull request references SREP-215 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@karanjitsingh01: This pull request references SREP-1215 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: karanjitsingh01 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @karanjitsingh01. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #372 +/- ##
==========================================
+ Coverage 49.00% 51.87% +2.86%
==========================================
Files 29 29
Lines 2116 2138 +22
==========================================
+ Hits 1037 1109 +72
+ Misses 973 922 -51
- Partials 106 107 +1 🚀 New features to boost your workflow:
|
…t_bundle_secret_if_exist
…t_bundle_secret_if_exist
originalTimestamp := originalSecret.CreationTimestamp.Time | ||
log.Log.Info(fmt.Sprintf("Original secret creation timestamp: %v", originalTimestamp)) | ||
|
||
err = clientset.CoreV1().Secrets(namespace_certman_operator).Delete(ctx, secretNameToDelete, metav1.DeleteOptions{}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think we should call the client and delete the secret
manually here.
We need to let the operator handle the deletion.
}, pollingDuration, 30*time.Second).Should(BeTrue(), "Certificate secret should be applied to apiserver object") | ||
}) | ||
|
||
It("delete secret, primary-cert-bundle-secret, if exists", func(ctx context.Context) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It("delete secret, primary-cert-bundle-secret, if exists", func(ctx context.Context) { | |
It("delete secret primary-cert-bundle-secret if exists", func(ctx context.Context) { |
@karanjitsingh01: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.