-
Notifications
You must be signed in to change notification settings - Fork 99
OCPBUGS-65498: Add openshift-dns-operator ClusterRole to ClusterOpera… #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@davidesalerno: This pull request references Jira Issue OCPBUGS-65498, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| relatedObjects: | ||
| - group: rbac.authorization.k8s.io | ||
| resource: clusterroles | ||
| name: openshift-dns-operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we add clusterrolebindings and serviceaccount as well?
- group: rbac.authorization.k8s.io
name: openshift-dns-operator
resource: clusterrolebindings
- group: ""
name: dns-operator
namespace: openshift-dns-operator
resource: serviceaccounts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked to the reporter
|
/retest-required |
1851043 to
1f934ab
Compare
|
/assign |
…tor relatedObjects Signed-off-by: Davide Salerno <[email protected]>
1f934ab to
98a37ae
Compare
|
@davidesalerno: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
…tor relatedObjects