OCPBUGS-65890: redirect catalog traffic as needed #15764

rhamilto · 2025-11-24T18:26:39Z

After:

Links that include query parameters such as OpenShift AI correctly redirect
The Ecosystem > Software Catalog nav link is unchanged
/catalog/all-namespaces redirects to /catalog/ns/default as it did before
/catalog/instantiate-template is unchanged

Screen.Recording.2025-11-24.at.1.22.24.PM.mov

/operatorhub is unchanged and redirects to /catalog/ns/default as it did before

Screen.Recording.2025-11-24.at.1.33.10.PM.mov

openshift-ci-robot · 2025-11-24T18:26:47Z

@rhamilto: This pull request references Jira Issue OCPBUGS-65890, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

After:

Links that include query parameters such as OpenShift AI correctly redirect

The Ecosystem > Software Catalog nav link is unchanged

/catalog/all-namespaces redirects to /catalog/ns/default as it did before

/catalog/instantiate-template is unchanged

Screen.Recording.2025-11-24.at.1.22.24.PM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2025-11-24T18:26:57Z

Walkthrough

Moved the catalog redirect component from the dev-console plugin into core app routing: removed its plugin route and exposed module, imported the component into core app-contents, added /catalog and /catalog/all-namespaces routes; component comment/type annotation changed, redirect logic unchanged.

Changes

Cohort / File(s)	Summary
Redirect component update `frontend/packages/console-shared/src/components/catalog/CatalogDefaultNamespaceRedirect.tsx`	Removed explicit React import, adjusted in-file comment and component type annotation (from `React.FC` to `React.FCC`); redirect logic still navigates to `/catalog/ns/default` preserving query params and replace behavior.
Plugin route removal `frontend/packages/dev-console/console-extensions.json`	Removed `console.page/route` entry for `"/catalog/all-namespaces"` that referenced `CatalogDefaultNamespaceRedirect`.
Plugin exposed module removal `frontend/packages/dev-console/package.json`	Removed `CatalogDefaultNamespaceRedirect` from `consolePlugin.exposedModules`.
Core routing addition `frontend/public/components/app-contents.tsx`	Imported `CatalogDefaultNamespaceRedirect` from shared package and added routes for `"/catalog"` and `"/catalog/all-namespaces"` that render the redirect component.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20–30 minutes

Verify no external consumers rely on the removed exposed module.
Confirm route ordering in app-contents.tsx doesn't conflict with existing routes.
Ensure the redirected URL, query-param preservation, and replace behavior are identical after migration.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between ab45f93 and 7ba80c2.

📒 Files selected for processing (4)

frontend/packages/console-shared/src/components/catalog/CatalogDefaultNamespaceRedirect.tsx (1 hunks)
frontend/packages/dev-console/console-extensions.json (0 hunks)
frontend/packages/dev-console/package.json (0 hunks)
frontend/public/components/app-contents.tsx (2 hunks)

💤 Files with no reviewable changes (2)

frontend/packages/dev-console/console-extensions.json
frontend/packages/dev-console/package.json

🧰 Additional context used

📓 Path-based instructions (1)

**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

frontend/public/components/app-contents.tsx
frontend/packages/console-shared/src/components/catalog/CatalogDefaultNamespaceRedirect.tsx

🔇 Additional comments (3)

frontend/public/components/app-contents.tsx (2)

20-20: LGTM!

The import correctly references the component from the console-shared package, aligning with the PR objective to move this redirect logic to core routing.

261-263: LGTM!

Both routes correctly use the redirect component to send catalog traffic to the default namespace. The component implementation preserves query parameters, which satisfies the PR requirement for OpenShift AI links with query params.

frontend/packages/console-shared/src/components/catalog/CatalogDefaultNamespaceRedirect.tsx (1)

4-4: The type annotation is correct and intentional—no changes needed.

FCC is defined in the codebase as a custom type for "a childless FunctionComponent". Since CatalogDefaultNamespaceRedirect doesn't accept or render children, using React.FCC is more semantically accurate than React.FC. This is a codebase convention applied consistently across the project, not an error.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

rhamilto · 2025-11-24T18:29:19Z

frontend/public/components/app-contents.tsx

        }
      />

+      <Route path="/catalog" element={<CatalogDefaultNamespaceRedirect />} />


Since we need <CatalogDefaultNamespaceRedirect> for both routes, I elected to move it to console-shared to ease reuse here.

openshift-ci-robot · 2025-11-24T18:34:26Z

@rhamilto: This pull request references Jira Issue OCPBUGS-65890, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

After:

Links that include query parameters such as OpenShift AI correctly redirect

The Ecosystem > Software Catalog nav link is unchanged

/catalog/all-namespaces redirects to /catalog/ns/default as it did before

/catalog/instantiate-template is unchanged

Screen.Recording.2025-11-24.at.1.22.24.PM.mov

/operatorhub is unchanged

Screen.Recording.2025-11-24.at.1.33.10.PM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rhamilto · 2025-11-24T22:25:55Z

/retest

frontend/packages/console-shared/src/components/catalog/CatalogDefaultNamespaceRedirect.tsx

logonoff

/lgtm

sg00dwin · 2025-11-25T17:12:54Z

/lgtm

sg00dwin · 2025-11-25T17:13:22Z

/test e2e-gcp-console

openshift-ci · 2025-11-25T17:16:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [logonoff,rhamilto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rhamilto · 2025-11-25T20:56:43Z

/retest

rhamilto · 2025-11-26T10:36:10Z

/retest

rhamilto · 2025-11-26T14:58:27Z

/retest

rhamilto · 2025-12-01T14:01:06Z

@yapei, can you please verify?

yapei · 2025-12-02T03:57:24Z

OpenShift AI now links to /catalog/ns/default?catalogType=operator&keyword=openshift+ai&selectedId=rhods-operator-redhat-operators-openshift-marketplace
click Ecosystem -> Software Catalog -> All Projects still redirects to /catalog/ns/default

/verified by @yapei

openshift-ci-robot · 2025-12-02T03:57:37Z

@yapei: This PR has been marked as verified by @yapei.

In response to this:

OpenShift AI now links to /catalog/ns/default?catalogType=operator&keyword=openshift+ai&selectedId=rhods-operator-redhat-operators-openshift-marketplace

click Ecosystem -> Software Catalog -> All Projects still redirects to /catalog/ns/default

/verified by @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-12-02T11:38:13Z

@rhamilto: Jira Issue Verification Checks: Jira Issue OCPBUGS-65890
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-65890 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

After:

Links that include query parameters such as OpenShift AI correctly redirect

The Ecosystem > Software Catalog nav link is unchanged

/catalog/all-namespaces redirects to /catalog/ns/default as it did before

/catalog/instantiate-template is unchanged

Screen.Recording.2025-11-24.at.1.22.24.PM.mov

/operatorhub is unchanged and redirects to /catalog/ns/default as it did before

Screen.Recording.2025-11-24.at.1.33.10.PM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2025-12-08T20:46:41Z

Fix included in accepted release 4.21.0-0.nightly-2025-12-08-112148

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 24, 2025

openshift-ci bot requested a review from yapei November 24, 2025 18:26

openshift-ci bot requested review from Leo6Leo and sg00dwin November 24, 2025 18:27

openshift-ci bot added component/core Related to console core functionality component/dev-console Related to dev-console approved Indicates a PR has been approved by an approver from all required OWNERS files. component/shared Related to console-shared labels Nov 24, 2025

rhamilto commented Nov 24, 2025

View reviewed changes

rhamilto force-pushed the OCPBUGS-65890 branch from 012ee97 to ab45f93 Compare November 24, 2025 18:32

logonoff reviewed Nov 25, 2025

View reviewed changes

frontend/packages/console-shared/src/components/catalog/CatalogDefaultNamespaceRedirect.tsx Outdated Show resolved Hide resolved

logonoff approved these changes Nov 25, 2025

View reviewed changes

OCPBUGS-65890: redirect catalog traffic as needed

7ba80c2

rhamilto force-pushed the OCPBUGS-65890 branch from ab45f93 to 7ba80c2 Compare November 25, 2025 16:06

logonoff approved these changes Nov 25, 2025

View reviewed changes

openshift-ci bot assigned logonoff Nov 25, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2025

sg00dwin approved these changes Nov 25, 2025

View reviewed changes

openshift-ci bot assigned sg00dwin Nov 25, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Dec 2, 2025

openshift-merge-bot bot merged commit e643fa3 into openshift:main Dec 2, 2025
7 of 8 checks passed

rhamilto deleted the OCPBUGS-65890 branch December 2, 2025 15:24

OCPBUGS-65890: redirect catalog traffic as needed #15764

OCPBUGS-65890: redirect catalog traffic as needed #15764

Conversation

rhamilto commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 24, 2025

Uh oh!

coderabbitai bot commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

rhamilto Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Nov 24, 2025

Uh oh!

rhamilto commented Nov 24, 2025

Uh oh!

Uh oh!

logonoff left a comment

Choose a reason for hiding this comment

Uh oh!

sg00dwin commented Nov 25, 2025

Uh oh!

sg00dwin commented Nov 25, 2025

Uh oh!

openshift-ci bot commented Nov 25, 2025

Uh oh!

rhamilto commented Nov 25, 2025

Uh oh!

rhamilto commented Nov 26, 2025

Uh oh!

rhamilto commented Nov 26, 2025

Uh oh!

rhamilto commented Dec 1, 2025

Uh oh!

yapei commented Dec 2, 2025

Uh oh!

openshift-ci-robot commented Dec 2, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Dec 2, 2025

Uh oh!

openshift-merge-robot commented Dec 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rhamilto commented Nov 24, 2025 •

edited

Loading

coderabbitai bot commented Nov 24, 2025 •

edited

Loading