Only use gateway PE IP for installer purposes if gateway is enabled#434
Conversation
openshift-ci
Bot
added
the
approved
|
@kimorris27: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
cadenmarchese
left a comment
cadenmarchese
left a comment
There was a problem hiding this comment.
lgtm, it makes sense to confirm gateway feature enablement rather than only confirming presence of GatewayPrivateEndpointIP in cosmos.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cadenmarchese, kimorris27 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit 915c21d
into
openshift:release-4.21
|
/cherrypick release-4.20 |
|
@kimorris27: new pull request created: #435 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick release-4.19 |
|
@kimorris27: new pull request created: #436 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick release-4.18 |
|
@kimorris27: new pull request created: #437 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
To accompany Azure/ARO-RP#4932. Not needed for prod - only needed for local dev and E2E.