Skip to content

Conversation

@Akrog
Copy link

@Akrog Akrog commented Nov 20, 2025

Description

On the GradioUI the system prompt displayed is always using the default system prompt, which is problematic when running the service with a custom system prompt (system_prompt_path) and allowing overriding it (enable_system_prompt_override: true).

With this simple patch we default to the configured system prompt on the GradioUI and only use the default system prompt if we don't have it configured.

Type of change

  • Bug fix

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

On the GradioUI the system prompt displayed is *always* using the
default system prompt, which is problematic when running the service
with a custom system prompt (`system_prompt_path`) and allowing
overriding it (`enable_system_prompt_override: true`).

With this simple patch we default to the configured system prompt on the
GradioUI and only use the default system prompt if we don't have it
configured.
@openshift-ci
Copy link

openshift-ci bot commented Nov 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xrajesh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Nov 20, 2025

@Akrog: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ols-cluster cd38b84 link true /test e2e-ols-cluster
ci/prow/integration cd38b84 link true /test integration
ci/prow/security cd38b84 link false /test security
ci/prow/verify cd38b84 link true /test verify
ci/prow/unit cd38b84 link true /test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant