Skip to content

NE-2447: Implement inspect_route tool#147

Open
bentito wants to merge 6 commits intoopenshift:mainfrom
bentito:feat/NE-2447-inspect-route
Open

NE-2447: Implement inspect_route tool#147
bentito wants to merge 6 commits intoopenshift:mainfrom
bentito:feat/NE-2447-inspect-route

Conversation

@bentito
Copy link

@bentito bentito commented Feb 16, 2026

This PR adds the inspect_route tool to the NetEdge toolset, enabling LLMs to analyze OpenShift Route configurations.

This tool is essential for the NetEdge diagnostic capabilities as it allows the agent to verify:

  • Ingress configuration (hostnames, paths, TLS termination)
  • Backend service routing and weights
  • Router status and admission conditions

By exposing these details, the agent can troubleshoot connectivity issues at the ingress layer.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 16, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 16, 2026

@bentito: This pull request references NE-2447 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This PR adds the inspect_route tool to the NetEdge toolset, enabling LLMs to analyze OpenShift Route configurations.

This tool is essential for the NetEdge diagnostic capabilities as it allows the agent to verify:

  • Ingress configuration (hostnames, paths, TLS termination)
  • Backend service routing and weights
  • Router status and admission conditions

By exposing these details, the agent can troubleshoot connectivity issues at the ingress layer.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Feb 16, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bentito
Once this PR has been reviewed and has the lgtm label, please assign kaustubh-pande for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bentito
Copy link
Author

bentito commented Feb 19, 2026

/retest

@bentito
Copy link
Author

bentito commented Feb 25, 2026

@matzew I think this one is ready, comments addressed

Copy link

@Thealisyed Thealisyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC this tool is returning the entire Route object? In that case, would it be more useful to have it highlight key fields relevant to troubleshooting (TLS termination type, host etc...) ??

@bentito
Copy link
Author

bentito commented Mar 2, 2026

IIUC this tool is returning the entire Route object? In that case, would it be more useful to have it highlight key fields relevant to troubleshooting (TLS termination type, host etc...) ??

I think that's a great idea! Thanks @Thealisyed

I refactored to return a structured object instead of just the raw JSON. The new output structure includes:

KeyFields: A top-level summary dictionary that extracts the most commonly targeted fields for diagnosing issues. This includes:
Name and Namespace
Host (spec.host)
TLS settings (spec.tls)
To backend reference (spec.to)
Port target (spec.port)
IngressStatus (the actual route admission status under status.ingress)
RawRoute: We still include the raw route object as a secondary payload so the agent retains access to the full configuration if deep inspection of edge cases is necessary.

This allows the LLM to immediately see the vital context.

@openshift-ci
Copy link

openshift-ci bot commented Mar 2, 2026

@bentito: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bentito
Copy link
Author

bentito commented Mar 10, 2026

/assign @matzew

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants