NE-2447: Implement inspect_route tool#147
Conversation
|
@bentito: This pull request references NE-2447 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bentito The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
|
@matzew I think this one is ready, comments addressed |
Thealisyed
left a comment
There was a problem hiding this comment.
IIUC this tool is returning the entire Route object? In that case, would it be more useful to have it highlight key fields relevant to troubleshooting (TLS termination type, host etc...) ??
Signed-off-by: bentito <btofel@redhat.com>
I think that's a great idea! Thanks @Thealisyed I refactored to return a structured object instead of just the raw JSON. The new output structure includes: KeyFields: A top-level summary dictionary that extracts the most commonly targeted fields for diagnosing issues. This includes: This allows the LLM to immediately see the vital context. |
|
@bentito: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/assign @matzew |
This PR adds the inspect_route tool to the NetEdge toolset, enabling LLMs to analyze OpenShift Route configurations.
This tool is essential for the NetEdge diagnostic capabilities as it allows the agent to verify:
By exposing these details, the agent can troubleshoot connectivity issues at the ingress layer.