-
Notifications
You must be signed in to change notification settings - Fork 22
[release-4.17] OCPBUGS-58408: Fix: One Alertmanager Config failing blocks all others. (#6585) #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-4.17
Are you sure you want to change the base?
Conversation
…perator#6585) * validation: added api url validation for Slack and Discord to stop hanging up the operator. * updated the changes according to the requirment. * Added secure validation for secret urls. Added ValidateSecretURL to securely validate url without logging it. * Added operator test cases for Secret Url validation. * Update according to changes made in alertmanager for config.SecretURL * fix(alertmanager): update error messages to follow standards. (cherry picked from commit 324ff7c)
@slashpai: This pull request references Jira Issue OCPBUGS-58408, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: slashpai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixing tests |
@slashpai: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/jira refresh |
@slashpai: This pull request references Jira Issue OCPBUGS-58408, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@slashpai: This pull request references Jira Issue OCPBUGS-58408, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
manual cherry-pick of prometheus-operator@324ff7c