-
Notifications
You must be signed in to change notification settings - Fork 37
Update io-lifetimes requirement from 0.6 to 0.7 #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updates the requirements on [io-lifetimes](https://github.com/sunfishcode/io-lifetimes) to permit the latest version. - [Release notes](https://github.com/sunfishcode/io-lifetimes/releases) - [Commits](sunfishcode/io-lifetimes@v0.6.0...v0.7.0) --- updated-dependencies: - dependency-name: io-lifetimes dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
|
Is |
No, it is only used internally. |
Sorry that I didn't notice this. But we would have to make a breaking change to remove that function. Perhaps we should just revert this PR? |
|
I think we should just remove the impl with a minor release. It's extremely unlikely anyone is relying on this part of the API right now, and it's okay to do a theoretically-breaking change in a non-major release if the likelihood of actual breakage is as low as here I think. |
Done in #82 ! |
Updates the requirements on io-lifetimes to permit the latest version.
Commits
f5b4dea(cargo-release) version 0.7.022ea30aAddFrom\<OwnedFd>andFrom\<T> for OwnedFdimpls.f80e1f0Make drop functions which are usually no-ops inline.e3b7794Remove obsolete TODOs.1b91650Remove sunfishcode.online docs.a7da11e(cargo-release) version 0.7.0-beta.0b3c7b00Make views require dedicatedunsafemarker traits. (#32)d520244(cargo-release) version 0.7.0-alpha.1c974453Avoid depending on panic in const fn, to fix compilaton on Rust <= 1.56.1fd4a53(cargo-release) version 0.7.0-alpha.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)