ovn: Add test for OVS configuration part of hardware offload. #1330
+31
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnordahl
added a commit
to fnordahl/charm-ovn-dedicated-chassis
that referenced
this pull request
Oct 13, 2025
At the time of initial implementation [0] of the ovn-dedicated-chassis, the use case known to us for hardware offload, required the combination of SR-IOV virtual functions and switchdev mode eswitch to be enabled. The purpose of the ovn-dedicated-chassis charm is to provide a principal charm that can be used to deploy a independent entity and have it serve as a network gateway, without hosting any virtual machines on the same entity. The need for a charm unit to manage SR-IOV only makes sense when you have virtual machines colocated with the charm unit, and as such this code was deemed inapplicable for the ovn-dedicated-chassis. There are however use cases where we want hardware offload to be enabled in OVS without the charm managing SR-IOV VFs nor the state of the switchdev mode. A concrete example is deployment to the arm64 operating sytem on BlueField, where hardware offload capable NIC is preconfigured to be in switchdev mode and no SR-IOV virtual functions are visible. Func-Test-PR: openstack-charmers/zaza-openstack-tests#1330 Reported-at: https://launchpad.net/bugs/2116862 Signed-off-by: Frode Nordahl <[email protected]>
fnordahl
added a commit
to fnordahl/charm-ovn-dedicated-chassis
that referenced
this pull request
Oct 13, 2025
At the time of initial implementation [0] of the ovn-dedicated-chassis, the use case known to us for hardware offload, required the combination of SR-IOV virtual functions and switchdev mode eswitch to be enabled. The purpose of the ovn-dedicated-chassis charm is to provide a principal charm that can be used to deploy a independent entity and have it serve as a network gateway, without hosting any virtual machines on the same entity. The need for a charm unit to manage SR-IOV only makes sense when you have virtual machines colocated with the charm unit, and as such this code was deemed inapplicable for the ovn-dedicated-chassis. There are however use cases where we want hardware offload to be enabled in OVS without the charm managing SR-IOV VFs nor the state of the switchdev mode. A concrete example is deployment to the arm64 operating sytem on BlueField, where hardware offload capable NIC is preconfigured to be in switchdev mode and no SR-IOV virtual functions are visible. Due to assumptions of dependent code we need to make the `sriov-numvfs` configuration option available [0]. Make the `enable-hardware-offload` configuartion option available. 0: https://github.com/juju/charm-helpers/blob/8f8c3fbe317070dc5c7d3bf9f196c6506dec7c7f/charmhelpers/contrib/openstack/context.py#L3343 Func-Test-PR: openstack-charmers/zaza-openstack-tests#1330 Reported-at: https://launchpad.net/bugs/2116862 Signed-off-by: Frode Nordahl <[email protected]>
Signed-off-by: Frode Nordahl <[email protected]>
fnordahl
added a commit
to fnordahl/charm-ovn-dedicated-chassis
that referenced
this pull request
Oct 13, 2025
At the time of initial implementation [0] of the ovn-dedicated-chassis, the use case known to us for hardware offload, required the combination of SR-IOV virtual functions and switchdev mode eswitch to be enabled. The purpose of the ovn-dedicated-chassis charm is to provide a principal charm that can be used to deploy an independent entity and have it serve as a network gateway, without hosting any virtual machines on the same entity. The need for a charm unit to manage SR-IOV only makes sense when you have virtual machines colocated with the charm unit, and as such this code was deemed inapplicable for the ovn-dedicated-chassis. There are however use cases where we want hardware offload to be enabled in OVS without the charm managing SR-IOV VFs nor the state of the switchdev mode. A concrete example is deployment to the arm64 operating system on BlueField, where hardware offload capable NIC is preconfigured to be in switchdev mode and no SR-IOV virtual functions are visible. Due to assumptions of dependent code we need to make the `sriov-numvfs` configuration option available [0]. Make the `enable-hardware-offload` configuration option available. 0: https://github.com/juju/charm-helpers/blob/8f8c3fbe317070dc5c7d3bf9f196c6506dec7c7f/charmhelpers/contrib/openstack/context.py#L3343 Func-Test-PR: openstack-charmers/zaza-openstack-tests#1330 Reported-at: https://launchpad.net/bugs/2116862 Signed-off-by: Frode Nordahl <[email protected]>
fnordahl
added a commit
to fnordahl/charm-ovn-dedicated-chassis
that referenced
this pull request
Oct 13, 2025
At the time of initial implementation [0] of the ovn-dedicated-chassis, the use case known to us for hardware offload, required the combination of SR-IOV virtual functions and switchdev mode eswitch to be enabled. The purpose of the ovn-dedicated-chassis charm is to provide a principal charm that can be used to deploy an independent entity and have it serve as a network gateway, without hosting any virtual machines on the same entity. The need for a charm unit to manage SR-IOV only makes sense when you have virtual machines colocated with the charm unit, and as such this code was deemed inapplicable for the ovn-dedicated-chassis. There are however use cases where we want hardware offload to be enabled in OVS without the charm managing SR-IOV VFs nor the state of the switchdev mode. A concrete example is deployment to the arm64 operating system on BlueField, where hardware offload capable NIC is preconfigured to be in switchdev mode and no SR-IOV virtual functions are visible. Due to assumptions of dependent code we need to make the `sriov-numvfs` configuration option available [0]. Make the `enable-hardware-offload` configuration option available. 0: https://github.com/juju/charm-helpers/blob/8f8c3fbe317070dc5c7d3bf9f196c6506dec7c7f/charmhelpers/contrib/openstack/context.py#L3343 Func-Test-PR: openstack-charmers/zaza-openstack-tests#1330 Reported-at: https://launchpad.net/bugs/2116862 Signed-off-by: Frode Nordahl <[email protected]>
fnordahl
added a commit
to fnordahl/charm-ovn-dedicated-chassis
that referenced
this pull request
Oct 14, 2025
At the time of initial implementation [0] of the ovn-dedicated-chassis, the use case known to us for hardware offload, required the combination of SR-IOV virtual functions and switchdev mode eswitch to be enabled. The purpose of the ovn-dedicated-chassis charm is to provide a principal charm that can be used to deploy an independent entity and have it serve as a network gateway, without hosting any virtual machines on the same entity. The need for a charm unit to manage SR-IOV only makes sense when you have virtual machines colocated with the charm unit, and as such this code was deemed inapplicable for the ovn-dedicated-chassis. There are however use cases where we want hardware offload to be enabled in OVS without the charm managing SR-IOV VFs nor the state of the switchdev mode. A concrete example is deployment to the arm64 operating system on BlueField, where hardware offload capable NIC is preconfigured to be in switchdev mode and no SR-IOV virtual functions are visible. Due to assumptions of dependent code we need to make the `sriov-numvfs` configuration option available [0]. Make the `enable-hardware-offload` configuration option available. 0: https://github.com/juju/charm-helpers/blob/8f8c3fbe317070dc5c7d3bf9f196c6506dec7c7f/charmhelpers/contrib/openstack/context.py#L3343 Func-Test-PR: openstack-charmers/zaza-openstack-tests#1330 Reported-at: https://launchpad.net/bugs/2116862 Signed-off-by: Frode Nordahl <[email protected]> (cherry picked from commit 3b21ecd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.