Add zaza tests for cert renewals for ovn-central #1332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arif-ali
added a commit
to arif-ali/charm-ovn-central
that referenced
this pull request
Dec 15, 2025
There are times when the certificate expires, and the charm goes into error state. This change ensures the right message is displayed, and the right actions can be taken. In errored state the vault reissue action doesn't work, this update would allow for the certs to be updated as the charm is not in error state. func-test-pr: openstack-charmers/zaza-openstack-tests#1332 Signed-off-by: Arif Ali <[email protected]>
arif-ali
added a commit
to arif-ali/charm-ovn-central
that referenced
this pull request
Dec 15, 2025
There are times when the certificate expires, and the charm goes into error state. This change ensures the right message is displayed, and the right actions can be taken. In errored state the vault reissue action doesn't work, this update would allow for the certs to be updated as the charm is not in error state. func-test-pr: openstack-charmers/zaza-openstack-tests#1332 Signed-off-by: Arif Ali <[email protected]>
arif-ali
added a commit
to arif-ali/charm-ovn-central
that referenced
this pull request
Dec 15, 2025
There are times when the certificate expires, and the charm goes into error state. This change ensures the right message is displayed, and the right actions can be taken. In errored state the vault reissue action doesn't work, this update would allow for the certs to be updated as the charm is not in error state. func-test-pr: openstack-charmers/zaza-openstack-tests#1332 Signed-off-by: Arif Ali <[email protected]>
arif-ali
added a commit
to arif-ali/charm-ovn-central
that referenced
this pull request
Dec 15, 2025
There are times when the certificate expires, and the charm goes into error state. This change ensures the right message is displayed, and the right actions can be taken. In errored state the vault reissue action doesn't work, this update would allow for the certs to be updated as the charm is not in error state. Func-test-pr: openstack-charmers/zaza-openstack-tests#1332 Signed-off-by: Arif Ali <[email protected]>
arif-ali
force-pushed
the
zaza-arif-ovn-cert-renewal
branch
7 times, most recently
from
ea41cdc to
91496b4
Compare
arif-ali
force-pushed
the
zaza-arif-ovn-cert-renewal
branch
from
91496b4 to
0db88f6
Compare
mkalcok
reviewed
Dec 18, 2025
Contributor
mkalcok
left a comment
mkalcok
left a comment
There was a problem hiding this comment.
Thank you for the improvement @arif-ali. LGTM.
OVN central tests completed successfully with this: canonical/charm-ovn-central#11
One question, is this test ovn-central specific? Or could it be called just OVNSSLExpireTests. And more importantly, does it make sense to introduce it to OVN chassis and dedicated chassis as well?
Contributor
Author
|
This is The certs for ovn-chassis get updated without any problems. In-fact I don't think the |
Contributor
|
Ack. Thanks. I wasn't sure of the top off my head about how client-side certs are handled in chassis charms. |
arif-ali
added a commit
to arif-ali/charm-ovn-central
that referenced
this pull request
Dec 19, 2025
There are times when the certificate expires, and the charm goes into error state. This change ensures the right message is displayed, and the right actions can be taken. In errored state the vault reissue action doesn't work, this update would allow for the certs to be updated as the charm is not in error state. Func-test-pr: openstack-charmers/zaza-openstack-tests#1332 Signed-off-by: Arif Ali <[email protected]>
arif-ali
added a commit
to arif-ali/charm-ovn-central
that referenced
this pull request
Jan 8, 2026
There are times when the certificate expires, and the charm goes into error state. This change ensures the right message is displayed, and the right actions can be taken. In errored state the vault reissue action doesn't work, this update would allow for the certs to be updated as the charm is not in error state. Func-test-pr: openstack-charmers/zaza-openstack-tests#1332 Signed-off-by: Arif Ali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for the charm changes as suggested from canonical/charm-ovn-central#11