Skip to content

Add Github action that verify PR and commit message prefix #3429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 11, 2025
Merged

Add Github action that verify PR and commit message prefix #3429

merged 2 commits into from
Nov 11, 2025

Conversation

@danpawlik
Copy link
Contributor

@danpawlik danpawlik commented Oct 21, 2025 •
edited by openshift-ci bot
Loading

If the PR is related to some role, it would verify if in the title or commit message header there is prefix set. For example, if change was done for roles/cifmw_helpers, it should verify if the title or commit message header contains [cifmw_helpers].

OSPRH-21366

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@danpawlik danpawlik force-pushed the add-gh-workflows-role-prefix-validator branch 13 times, most recently from fb11d54 to 337bc30 Compare October 23, 2025 12:21
@danpawlik danpawlik marked this pull request as ready for review October 23, 2025 12:21
@danpawlik danpawlik requested a review from a team as a code owner October 23, 2025 12:21
@danpawlik danpawlik force-pushed the add-gh-workflows-role-prefix-validator branch from 337bc30 to 3215fc3 Compare October 24, 2025 11:37
@danpawlik danpawlik force-pushed the add-gh-workflows-role-prefix-validator branch 11 times, most recently from 24f38a9 to 8e11bb3 Compare November 5, 2025 07:54
@danpawlik
Copy link
Contributor Author

danpawlik commented Nov 5, 2025

Change needs to be merged to provide comment.
Example usage: danpawlik#1

@danpawlik danpawlik marked this pull request as ready for review November 5, 2025 07:54
@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Nov 5, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1dc89fa0d0374244ad81990a4eb9ca1d

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 53m 12s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 13m 42s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 39m 29s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 37s
❌ cifmw-pod-pre-commit FAILURE in 8m 12s
✔️ build-push-container-cifmw-client SUCCESS in 16m 54s

@danpawlik danpawlik force-pushed the add-gh-workflows-role-prefix-validator branch from 8e11bb3 to 8c9b696 Compare November 5, 2025 12:54
@danpawlik @sdatko
Add Github action that verify commit message prefix
7a0efb5 
If the PR is related to some role, it would verify if in the title or
commit message header there is prefix set.
For example, if change was done for roles/cifmw_helpers, it should
verify if the title or commit message header contains [cifmw_helpers].

Co-Authored-By: Szymon Datko <[email protected]>
Signed-off-by: Daniel Pawlik <[email protected]>
@danpawlik danpawlik force-pushed the add-gh-workflows-role-prefix-validator branch from 8c9b696 to 7a0efb5 Compare November 6, 2025 10:19
@danpawlik @sdatko
Add Github action that verify commit message prefix
2a8cc26 
If the PR is related to some role, it would verify if in the title or
commit message header there is prefix set.
For example, if change was done for roles/cifmw_helpers, it should
verify if the title or commit message header contains [cifmw_helpers].

Co-Authored-By: Szymon Datko <[email protected]>
Signed-off-by: Daniel Pawlik <[email protected]>
@danpawlik danpawlik force-pushed the add-gh-workflows-role-prefix-validator branch from d9ce2aa to 2a8cc26 Compare November 6, 2025 10:33
@danpawlik
Copy link
Contributor Author

danpawlik commented Nov 6, 2025

Contribution info was added #3437

@evallesp
Copy link
Contributor

evallesp commented Nov 10, 2025

recheck

@amartyasinha amartyasinha merged commit 5f9f0fa into openstack-k8s-operators:main Nov 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evallesp evallesp evallesp approved these changes

@brjackma brjackma brjackma approved these changes

@abays abays Awaiting requested review from abays

@Valkyrie00 Valkyrie00 Awaiting requested review from Valkyrie00

@tosky tosky Awaiting requested review from tosky

@sdatko sdatko Awaiting requested review from sdatko

@amartyasinha amartyasinha Awaiting requested review from amartyasinha

Assignees

No one assigned

Labels

Ready For Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@danpawlik @evallesp @brjackma @amartyasinha