Adding json type files to crawl_n_mask

[evallesp]

We're adding json type files to crawl_n_mask.
It checks the extension and return the value of the masked key different between yaml and json formats.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[danpawlik]

Generally it looks ok, but want to see result

[michburk]

I did a test running the module locally with some basic examples. I noticed that in JSON files, the secrets get masked slightly differently than in yaml files. I ran crawl_n_mask on a dir with the following yaml and json files.
yaml file:

---
password: password123

json file:

{
  "password": "password123"
}

after crawling the dir, the files look like:

---
password: 'pa**********23'

{
    "password": "p**********3"
}

The secret in the yaml file is masked as expected, but it seems that in the json file, the double quotes surrounding the actual secret are counted as part of the secret's length.

[michburk]

Could move this key.strip().replace('"', "") into a variable calculated just above the for loop in order to avoid constantly re-evaluating these string operations while we check the same key against each new word in PROTECT_KEYS.

[evallesp]

I did a test running the module locally with some basic examples. I noticed that in JSON files, the secrets get masked slightly differently than in yaml files. I ran crawl_n_mask on a dir with the following yaml and json files. yaml file:

---
password: password123

json file:

{
  "password": "password123"
}

after crawling the dir, the files look like:

---
password: 'pa**********23'

{
    "password": "p**********3"
}

The secret in the yaml file is masked as expected, but it seems that in the json file, the double quotes surrounding the actual secret are counted as part of the secret's length.

Good catch. I've updated the PR, but waiting the testproject results

[michburk]

Json masking is working properly now in my local tests 👍

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/36c4a133dea84791b8f96f3a6d087a22

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 36m 26s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 18m 20s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 21m 58s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 40s
❌ cifmw-pod-pre-commit FAILURE in 7m 49s
✔️ build-push-container-cifmw-client SUCCESS in 17m 29s

[danpawlik]

@evallesp re-run black on the python file and we can go

[evallesp]

@evallesp re-run black on the python file and we can go

done

[evallesp]

Check METADATA_SHARED_SECRET:
This MR: https://logserver.rdoproject.org/cae/rdoproject.org/cae92f0e6611477eaf0a2cc484e928f8/job-output.json
Without this change: https://logserver.rdoproject.org/f0e/rdoproject.org/f0efc6eb24d640e1b9fd9fd93d11db0c/job-output.json

[evallesp]

I think this is redundant since the creation of: #3447