Set timeout in each oc adm must-gather command execution #3440
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It happens that the "oc adm must-gather" command takes longer
than expected, so the CI job gets timeout and the collecting
logs process is disturbed. In some places, we spotted that the
'--timeout' parameter in 'oc adm' command is just ignored:
TASK [os_must_gather : Run openstack-must-gather command
output_dir={{ cifmw_os_must_gather_output_dir }}/artifacts,
script=oc adm must-gather --image {{ cifmw_os_must_gather_image }}
--timeout {{ cifmw_os_must_gather_timeout }}
--host-network={{ cifmw_os_must_gather_host_network }}
--dest-dir {{ cifmw_os_must_gather_output_log_dir }}
-- ADDITIONAL_NAMESPACES={{ cifmw_os_must_gather_additional_namespaces }}
OPENSTACK_DATABASES=$OPENSTACK_DATABASES SOS_EDPM=$SOS_EDPM SOS_DECOMPRESS=$SOS_DECOMPRESS gather 2>&1]
POST-RUN END RESULT_TIMED_OUT: [untrusted : playbooks/baremetal/collect-logs.yaml@main]
so let's add also timeout before 'oc adm' command to make sure
that it would be "killed" in proper amount of time.
Signed-off-by: Daniel Pawlik <[email protected]>
danpawlik
force-pushed
the
add-timeout-must-gather
branch
from
e44143a to
3588da3
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b05b0f1a21754500a576a05ed9c44cb1 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 55m 43s |
|
Need to test it first. |
|
Checking in testproject 1675 |
|
recheck |
5 participants
It happens that the "oc adm must-gather" command takes longer
than expected, so the CI job gets timeout and the collecting
logs process is disturbed. In some places, we spotted that the
'--timeout' parameter in 'oc adm' command is just ignored:
so let's add also timeout before 'oc adm' command to make sure
that it would be "killed" in proper amount of time.
OSPRH-21369