-
Notifications
You must be signed in to change notification settings - Fork 139
Configure additional DHCP host records for hybrid scenarios, fix nova04delta template #3443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d7397e2 to
afcd863
Compare
afcd863 to
f566529
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7ec1e98a2ae54adfb33cb7b44ed858bd ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 36m 48s |
02fb1c7 to
f046123
Compare
|
We need this hook for VAF team hybrid setup full-routing solution for virtual-media. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2c06d56015aa4e5594ddb76710599991 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 47m 53s |
|
Folks, why |
|
it also fails on main branch |
|
recheck |
f046123 to
bd30d4b
Compare
|
we have tested this in testproject downstream |
a66cafb to
bd36b5f
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d608b3f716b54724a236a71ff4706b27 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 10s |
Full routing solution for hybrid scenarios involving virtual-media BMO, requires extra host record for hypervisor host pointing out to ocpbm bridge IP. Add a playbook to create this record, which can be applied as a post_infra hook. Note that neither _vm_records, nor cifmw_dnsmasq_host_record can't be used for this currently. Signed-off-by: Bohdan Dobrelia <[email protected]>
Signed-off-by: Bohdan Dobrelia <[email protected]>
bd36b5f to
b05fb34
Compare
|
/lgtm |
Signed-off-by: Bohdan Dobrelia <[email protected]>
|
sorry, I pushed another fix on top |
danpawlik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can live without handlers here.
|
/lgtm |
|
/cherry-pick stable |
|
@bogdando: new pull request created: #3459 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Full routing solution for hybrid scenarios involving virtual-media BMO, requires extra host record for hypervisor host pointing out to ocpbm bridge IP.
Add a playbook to create this record, which can be applied as a post_infra or pre-deploy hook. Note that neither _vm_records, nor cifmw_dnsmasq_host_record can't be used for this currently.
Fix nova04delta cifmw_baremetal_hosts defaults
Set the condition for cifmw_baremetal_hosts to be defined and non-empty in nova04delta template, which lets the nova04delta DT passing the architecture repo validation for building CI jobs.
Do not repeat edpm services for nova04delta template
Consume those from the base DT layer plus overrides in VAF job file, if any.
JIRA: OSPRH-18909