Add predictableIPs label to pods #394
Conversation
This commit adds an helper label to each pod with the value of its predictableip. This is useful if we want to then use this value to afterwards advertise the IP address using frr, instead of having to introspect the designate configmaps. Jira: https://issues.redhat.com/browse/OSPRH-20083
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lmiccini The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm cool! |
| IPKeyPrefix: "bind_address_", | ||
| ServiceName: "designate-backendbind9", | ||
| } | ||
| err = designate.HandlePodLabeling(ctx, helper, instance.Name, instance.Namespace, config) |
There was a problem hiding this comment.
We call this function every reconcile loop, and if I understand correctly, we list all of the pods of the deployment and then filter for the designate ones. We might want to implement a mechanism to call it only when the configmap changes, e.g. comparing hashes as we do with the pools.yaml generation. But we can implement that in a future patch if we see that it is necessary.
|
I left a comment but I am ok with merging it as is. Thank you Luca for working on this PR! |
|
/lgtm |
3 participants
This commit adds an helper label to each pod with the value of its predictableip.
This is useful if we want to then use this value to afterwards advertise the IP address using frr, instead of having to introspect the designate configmaps.
Jira: https://issues.redhat.com/browse/OSPRH-20083