Skip to content

Re-add --webhook-bind-address flag #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Re-add --webhook-bind-address flag #553

wants to merge 1 commit into from
+3 −0

Conversation

@stuggi
Copy link
Contributor

@stuggi stuggi commented Nov 25, 2025

Re-adds support for configuring the webhook server port through the --webhook-bind-address command-line flag (default: 9443).

This flag was previously removed and needs to be restored to support local development and testing scenarios.

@stuggi
Re-add --webhook-bind-address flag
043ccf3 
Re-adds support for configuring the webhook server port through the
--webhook-bind-address command-line flag (default: 9443).

This flag was previously removed and needs to be restored to support
local development and testing scenarios.

Signed-off-by: Martin Schuppert <[email protected]>
@stuggi stuggi requested a review from abays November 25, 2025 09:59
abays
abays approved these changes Nov 25, 2025
View reviewed changes
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 25, 2025
fernandoroyosanchez
fernandoroyosanchez approved these changes Nov 25, 2025
View reviewed changes
Copy link
Contributor

@fernandoroyosanchez fernandoroyosanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, fernandoroyosanchez, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abays,fernandoroyosanchez,stuggi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stuggi
Copy link
Contributor Author

stuggi commented Nov 25, 2025

/retest

@abays
Copy link
Contributor

abays commented Nov 25, 2025

/test octavia-operator-build-deploy-kuttl

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 25, 2025

@stuggi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/octavia-operator-build-deploy-kuttl 043ccf3 link true /test octavia-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abays abays abays approved these changes

@fernandoroyosanchez fernandoroyosanchez fernandoroyosanchez approved these changes

@karelyatin karelyatin Awaiting requested review from karelyatin

Assignees

@abays abays

@fernandoroyosanchez fernandoroyosanchez

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stuggi @abays @fernandoroyosanchez