-
Notifications
You must be signed in to change notification settings - Fork 59
Replace mod_wsgi with uwsgi for designateapi #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Replace mod_wsgi with uwsgi for designateapi #282
Conversation
mod_wsgi is being removed from upstream sources but OpenStack APIs are still using it downstream, which is very concerning. This patch replaces mod_wsgi with uwsgi.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: omersch381 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/40482290cefc465795b827451d4535fb ❌ openstack-meta-content-provider FAILURE in 20m 07s |
mod_wsgi is being removed from upstream sources but OpenStack APIs are still using it downstream, which is very concerning. This patch aims to replace mod_wsgi with uwsgi. Depends-On: openstack-k8s-operators/tcib#282
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
multiple services do use mod_wsgi. If there is upgrade impact for rhel/centos 10 related to this package, please create a jira issue and link it here.
My concern is that we should get this acked by the release delivery team, I am not sure uwsgi switch would be straightforward
@SeanMooney FYI
that is not actully correct. we simply changed how we package the wsgi applcation with in the git trees. for what it worth i would like to see us move to gunicorn, uvicorn or uwsgi. so i dont nessiarly see a problem with designate moving now. we filed https://issues.redhat.com/browse/RHOSSTRAT-220 in 2023 becasue we wanted to intially od this before 18 released to slim down our contianers. for nova/placement the switch woudl be pretty easy provide we have the package. the main concern is with ssl termination and ensuring we can still terminate it in the api pod. designate-operator can simply provide wa wsgi file or point mod_wsgi at the python module that was added upstream as part fo addign supprot for pyproject.toml and the module based wsgi supprot |
my the way if i understand the curernt patch correctly the intent was to continue to run apache with mod_ssl todo the tls termination and uwsgi as a second container in the same pod to actully run the actual designate api. this is exactly how we test with devstack and is a production ready solution so its might eb a first step in the process of removign apache. i agree with bogdando that checkign with the release team to ensure there are not packaging concerns with uwsgi before proceeding. uwsgi is currently in mantiance mode which is why i suggested gunicorn which is more maintianed and used by some project like ironic upstream. |
@SeanMooney I think that Jira probably needs to be swapped out for something else - it's asking for action before we even know what that action would be and whether release teams can support it. I don't see any pressing need to do this in 18 though? |
mod_wsgi is being removed from upstream sources but OpenStack APIs are still using it downstream, which is very concerning.
This patch replaces mod_wsgi with uwsgi.