Fixup POD_DEBUG var

[lmiccini]

According to the spec the default value for POD_DEBUG should be false but this value is not passed properly to the pod, so we end up using the default entrypoint script value (true).

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f4b2c3b25739475a9a6951a977c8e775

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 08m 48s
❌ podified-multinode-edpm-deployment-crc-test-operator FAILURE in 1h 58m 29s

[lpiwowar]

recheck

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c23d00b2d1304ea19140a5324573c389

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 36m 09s
❌ podified-multinode-edpm-deployment-crc-test-operator FAILURE in 2h 26m 07s

[lpiwowar]

recheck

[lpiwowar]

There seems to be an issue with tobiko -> https://logserver.rdoproject.org/632/rdoproject.org/632dde05c1e2439fa1fe28cfaa8f911c/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack/pods/tobiko-tests-tobiko-s00-podified-functional/logs/tobiko-tests-tobiko.log

If it persists we should talk with somebody from the Tobiko team.

[kstrenkova]

I have no problem with these changes, but if the value is not propagated properly I think we should also fix the root of the problem. This is only a workaround for the real issue, if I understood it correctly.

[lmiccini]

I have no problem with these changes, but if the value is not propagated properly I think we should also fix the root of the problem. This is only a workaround for the real issue, if I understood it correctly.

Do you prefer we switch to default=false in tcib?
I would argue that we still need this patch because the spec default value is false but this "false" value is not passed to the pod anyway, regardless of the tcib default.

[kstrenkova]

/lgtm

Sounds reasonable. However, I would say that the value could be still set to false in TCIB. To me the name pod debug evokes that we want to only use it while debugging, so I don't see why the default would be true. But feel free to correct me.

[lpiwowar]

/approve

+1 for the idea of fixing this in TCIB as well. The default should be false there as well.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmiccini, lpiwowar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lpiwowar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lmiccini]

openstack-k8s-operators/tcib#289

[lpiwowar]

@lmiccini thanks!