DNM Checking removing nested ansible execution for 99-logs #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was exception done for run_logs tasks in cifmw_setup role, that calling that role was used in e2e-collect-logs using ansible binary (not ansible-playbook as it is in multiple places). There is no need to run as nested ansible, if it can be called directly. Depends-On: openstack-k8s-operators/ci-framework#3242 Signed-off-by: Daniel Pawlik <[email protected]>
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was exception done for run_logs tasks in cifmw_setup role, that calling that role was used in e2e-collect-logs using ansible binary (not ansible-playbook as it is in multiple places). There is no need to run as nested ansible, if it can be called directly.
Depends-On: openstack-k8s-operators/ci-framework#3242