removing Volume Modules, Redirecting in runtime.yml#95
Open
SebastianGode wants to merge 9 commits intomainfrom
Open
removing Volume Modules, Redirecting in runtime.yml#95SebastianGode wants to merge 9 commits intomainfrom
SebastianGode wants to merge 9 commits intomainfrom
Conversation
Member
Author
|
recheck |
Member
Author
|
I needed to change the volume_backup_info integration test as it was looking whether "backups" is defined and the native openstack module calls it "volume_backups" so it was failing. This may have impact on older Scripts and it may need another workaround |
Member
Author
|
recheck |
1 similar comment
Member
Author
|
recheck |
![otc-zuul[bot]](https://avatars.githubusercontent.com/in/11628?s=60&v=4){kind=small}
tischrei
previously approved these changes
Mar 29, 2021
Member
Author
|
recheck |
gtema
requested changes
Apr 30, 2021
Collaborator
gtema
left a comment
gtema
left a comment
There was a problem hiding this comment.
except of need to drop too much rerouting (for things not even existing in OTC) and merge conflict - good to go
| redirect: openstack.cloud.volume_snapshot_info | ||
| auth: | ||
| redirect: openstack.cloud.auth | ||
| baremetal_inspect: |
Collaborator
There was a problem hiding this comment.
baremetal things are not necessary for us
| redirect: openstack.cloud.catalog_endpoint | ||
| catalog_service: | ||
| redirect: openstack.cloud.catalog_service | ||
| coe_cluster: |
| redirect: openstack.cloud.catalog_service | ||
| coe_cluster: | ||
| redirect: openstack.cloud.coe_cluster | ||
| coe_cluster_template: |
| redirect: openstack.cloud.config | ||
| endpoint: | ||
| redirect: openstack.cloud.endpoint | ||
| federation_idp: |
Collaborator
There was a problem hiding this comment.
all federation is not working as intended - remove it
| redirect: openstack.cloud.federation_mapping_info | ||
| group_assignment: | ||
| redirect: openstack.cloud.group_assignment | ||
| host_aggregate: |
| redirect: openstack.cloud.keypair | ||
| keypair_info: | ||
| redirect: openstack.cloud.keypair_info | ||
| keystone_federation_protocol: |
| redirect: openstack.cloud.volume_info | ||
| volume_snapshot: | ||
| redirect: openstack.cloud.volume_snapshot | ||
|
|
Collaborator
There was a problem hiding this comment.
ah, it is at the top - please move it here (alphabetical)
Member
Author
|
recheck |
Member
Author
|
recheck |
1 similar comment
Member
Author
|
recheck |
gtema
approved these changes
Jul 13, 2021
|
Build failed.
|
|
Build failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed all volume_xx modules as they were replaced by openstack native ones #89
I redirected all modules we don't have in our collection to native openstack ones so that it's not necessary to use the full FQDN now. For example Instead of
openstack.cloud.serveryou can now just writeserverin integration tests oropentelekomcloud.cloud.serverwhich makes it simpler to use the modules.Closes #89