Skip to content

Improved Test Running + Race Condition Catch #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 17, 2025
Merged

Improved Test Running + Race Condition Catch #236

merged 12 commits into from
Nov 17, 2025

Conversation

@thewhaleking
Copy link
Collaborator

@thewhaleking thewhaleking commented Nov 17, 2025 •
edited
Loading

  1. Improves test runners
  2. Catches race conditions that previously could lead to premature shutdown, which could cause an infinite lock
  3. Adds test for AsyncSubstrateInterface.wait_for_block

@github-actions github-actions bot added run-bittensor-sdk-tests Runs Bittensor SDK tests. run-bittensor-cli-tests Runs BTCLI tests. labels Nov 17, 2025
@thewhaleking thewhaleking changed the title Better testing maybe Improved Test Running + Race Condition Catch Nov 17, 2025
@thewhaleking thewhaleking requested a review from a team November 17, 2025 19:54
@thewhaleking thewhaleking merged commit 7f7e058 into staging Nov 17, 2025
29 checks passed
@thewhaleking thewhaleking deleted the fix/thewhaleking/better-testing-maybe branch November 17, 2025 20:28
@thewhaleking thewhaleking mentioned this pull request Nov 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ibraheem-abe ibraheem-abe ibraheem-abe approved these changes

@basfroman basfroman basfroman approved these changes

Assignees

No one assigned

Labels

run-bittensor-cli-tests Runs BTCLI tests. run-bittensor-sdk-tests Runs Bittensor SDK tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thewhaleking @ibraheem-abe @basfroman