Refactor TypeScript types to use official OpenTok SDK types #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… types, update tsconfig - Removed most of the custom OpenTok types in favor of official @opentok/client types - Kept minimal custom types: PublisherStats, InitSessionOptions, SessionCredentials, RTCIceCandidateStats - Updated tsconfig.json to include "dom.iterable" to allow RTCStatsReport.values() - Removed @types/webrtc and @types/opentok
LukaszPilarski
approved these changes
Oct 14, 2025
|
@LukaszPilarski Sorry, I found a bug in the code; I forgot to rename it in two places. I tested this package in the project even without the latest changes, and it still worked because OT is globally accessible anyway. But now it's safer. Could you check it again and approve it? |
LukaszPilarski
approved these changes
Oct 15, 2025
|
@vatson I resolved the conflicts. Please check if everything still works fine, after that I will reapprove. |
|
@LukaszPilarski thanks for notification. I checked and added proper changes. Now everything looks good |
LukaszPilarski
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor TypeScript types to use official OpenTok SDK types where possible, removing outdated custom types. This improves compatibility with the latest OpenTok SDK and reduces maintenance overhead.
Current example of conflict with opentok 2.29.2
Details
Removed most of the custom OpenTok types from
src/NetworkTest/types/opentok/*.Kept only minimal custom types that could not be safely replaced with official types:
PublisherStats— differs fromOT.PublisherStats.InitSessionOptions— for explicit session initialization safety.SessionCredentials— combines parameters frominitSessionandconnect.RTCIceCandidateStats— WebRTC native types lacktimestampandprotocol.Updated
tsconfig.jsonto include"dom.iterable"inlibto allow usage ofRTCStatsReport.values().Removed
@types/webrtcand@types/opentokfrompackage.jsonas they are no longer necessary and conflicted with official@opentok/clienttypes.This change simplifies type management and makes the project compatible with the latest OpenTok SDK versions.