Bump up version of ml-transformers lib in Moderate-Background-Blur and Moderate-Background-Image sample apps #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d Moderate-Background-Image sample apps
|
@conshus, can you please help us review? We found an issue when trying to run the app using more recent versions of the ML lib. Thanks! 🙏 |
…d Moderate-Background-Image sample apps
joliveraortega
commented
May 23, 2025
|
|
||
| const bgUrl1 = "https://neru-b617e2b2-basic-dev.euw1.runtime.vonage.cloud/bg-1.png"; | ||
| const bgUrl2 = "https://neru-b617e2b2-basic-dev.euw1.runtime.vonage.cloud/bg-2.png"; | ||
|
|
There was a problem hiding this comment.
These are not found as of today. Happy to change them with the ones you guys share.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
Bump up version of ml-transformers lib in Moderate-Background-Blur and Moderate-Background-Image sample apps
There are some additions to the config object where it is shown how to provide the ML assets when hosting them (not using the default ones pulled from a default location).
How should this be manually tested?
Follow https://github.com/opentok/opentok-web-samples/tree/main/Moderate-Background-Blur#readme and https://github.com/opentok/opentok-web-samples/tree/main/Moderate-Background-Image#readme.