-
Notifications
You must be signed in to change notification settings - Fork 285
[CI][GHA] Enable GGUF Test on MacOS #2497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[CI][GHA] Enable GGUF Test on MacOS #2497
Conversation
@@ -20,8 +20,6 @@ | |||
@pytest.mark.parametrize("model_ids", get_gguf_model_list()) | |||
@pytest.mark.precommit | |||
def test_pipelines_with_gguf_generate(pipeline_type, model_ids): | |||
if sys.platform == 'darwin': | |||
pytest.skip(reason="168882: Sporadic segmentation fault failure on MacOS.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JIRA ticket is still opened: https://jira.devtools.intel.com/browse/CVS-168882
Where is the fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, our previous assumption that segment issue may related to limited disk storage in GHA CI machine, #2488 merged to mitigate this issue.
It turn out the segment fault issue it not related to disk storage issue, it is still not root cause and not reproducible in local mac machine from validation team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, as I mentioned above, this segment fault issue still exists, and not found the root cause yet, may need your suggestions to move forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can ignore the problem assuming it's x86 specific. It's going to be dropped by OV: https://www.intel.com/content/www/us/en/developer/articles/release-notes/openvino/2025-2.html
MacOS x86 is no longer recommended for use due to the discontinuation of validation. Full support will be removed later in 2025.
I'd propose to switch to ticket 171090
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JIRA ticket is still opened: https://jira.devtools.intel.com/browse/CVS-168882
Can revisit after #2533 merge. |
Details
Re-enable GGUF reader test on MacOS after #2488
Ticket
CVS-168882