Skip to content

[JS] Add build NodeJS bindings into Manylinux 2_28 #2537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 27, 2025
Merged

[JS] Add build NodeJS bindings into Manylinux 2_28 #2537

merged 13 commits into from
Aug 27, 2025

Conversation

Retribution98
Copy link
Contributor

@Retribution98 Retribution98 commented Aug 5, 2025 •
edited
Loading

Node.js 22 requires the CXX11 ABI. ManyLinux 2014 uses an older version of GCC that does not support the CXX11 ABI.

Details

  • Add the building of JS bindings to ManyLinux 2.28

Tickets

@github-actions github-actions bot added the category: GHA CI based on Github actions label Aug 5, 2025
@Retribution98 Retribution98 marked this pull request as ready for review August 25, 2025 07:23
@Copilot Copilot AI review requested due to automatic review settings August 25, 2025 07:23
@Retribution98 Retribution98 requested a review from akladiev August 25, 2025 08:56
Copilot
Copilot AI reviewed Aug 25, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions github-actions bot added the category: cmake / build Cmake scripts label Aug 25, 2025
@github-actions github-actions bot removed the category: cmake / build Cmake scripts label Aug 25, 2025
@Retribution98 Retribution98 requested a review from mryzhov August 25, 2025 14:16
akladiev
akladiev reviewed Aug 26, 2025
View reviewed changes
akladiev
akladiev reviewed Aug 26, 2025
View reviewed changes
@Retribution98 Retribution98 force-pushed the build_nodejs_manylinux_2_28 branch from 545ab72 to 4067314 Compare August 26, 2025 09:38
@Retribution98 Retribution98 requested a review from akladiev August 26, 2025 11:09
@Retribution98 Retribution98 force-pushed the build_nodejs_manylinux_2_28 branch from 4067314 to 6b8acef Compare August 26, 2025 12:02
akladiev
akladiev reviewed Aug 26, 2025
View reviewed changes
akladiev
akladiev reviewed Aug 26, 2025
View reviewed changes
@akladiev akladiev requested a review from akashchi August 27, 2025 09:36
@Retribution98 Retribution98 added this pull request to the merge queue Aug 27, 2025
Merged via the queue into openvinotoolkit:master with commit b9a5efd Aug 27, 2025
187 of 197 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@akladiev akladiev akladiev approved these changes

@mryzhov mryzhov Awaiting requested review from mryzhov

@akashchi akashchi Awaiting requested review from akashchi

Assignees
No one assigned
Labels
category: GHA CI based on Github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Retribution98 @akladiev